1599016 - [Wayland] Don't use GL_TEXTURE_EXTERNAL_OES textures with dmabuf backend

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

According to https://gitlab.freedesktop.org/mesa/mesa/issues/2119 we should remove GL_TEXTURE_EXTERNAL_OES and use just plain GL_TEXTURE_2D.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: wip

There's a WIP patch for it but I still have Webrender with external texture, I wonder if I need also update some rust code for it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Sotaro, do you know how WebRender get texture target for shaders? I'm unable to persuade it to use TEXTURE_2D as it still uses TEXTURE_EXTERNAL. May it be due to EGLImage used here?
Thanks.

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Martin Stránský [:stransky] from comment #2)

Sotaro, do you know how WebRender get texture target for shaders? I'm unable to persuade it to use TEXTURE_2D as it still uses TEXTURE_EXTERNAL. May it be due to EGLImage used here?

WaylandDMABUFTextureHostOGL::PushResourceUpdates() set texture target type of WebRender as wr::TextureTarget::External. Changing it seems to affect to final OpenGL texture target type.
https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/layers/opengl/WaylandDMABUFTextureHostOGL.cpp#111

The gl target type is selected at get_gl_target()
https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/wr/webrender/src/device/gl.rs#179

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1599016 [Wayland] Don't use GL_TEXTURE_EXTERNAL_OES textures with DMA BUF backend, r?sotaro

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d0efb589757
[Wayland] Don't use GL_TEXTURE_EXTERNAL_OES textures with DMA BUF backend, r=sotaro

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6d0efb589757