1599046 - Moving the ContentBlockingLog to the parent process

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Dimi Lee [:dimi][:dlee]]

Right now, the ContentBlockingLog is located on the document of the top-level window. This is incompatible to the Fission since the top-level window might not be accessible if it is cross-origin.
In order to make this work in the Fission. We'll remove ContentBlockingLog from the child process and store it in the parent process instead.

Comment 1

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1599046 - P1. Remove ContentBlockingLog from the child r=timhuang

At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:

1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.

Comment 2

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1599046 - P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang

As the final step, all the callsites of NotifyOnContentBlocking should
be removed.

Depends on D56874

Comment 4

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1599046 - P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang

This patch does the followings:

1. Remove NotifyOnContentBlocking in WindowOuter and all the call sites.
   This is because all the content blocking event handling is moved to the parent.

2. Replace UrlClassifierCommon::NotifyChannelBlocked with AntiTrackingCommon:::NotifyContentBlockingEventInParent.
   This is because we don't need to pass the request to the child anymore, which was implemented in NotifyChannelBlocked previously.

3. Add NotifyContentBlockingEvent* utility functions to AntiTrackingCommon.cpp.

4. Update AntiTrackingCommon::NotifyBlockingDecision, when it is called in the parent,
   do not send requests to the child, notify the parent directly

Comment 5

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1599046 - P3. Remove unused IPC method in nsIParentChannel.idl. r=timhuang

The following methods are removed:

1. notifyChannelClassifierProtectionDisabled
2. notifyCookieAllowed
3. notifyCookieBlocked

Comment 6

[Dimi Lee [:dimi][:dlee]]

Attachment: Bug 1599046 - P4. Report content blocking log to console while running in the parent process r=timhuang

Comment 7

[(no longer active)]

Can these changes land now?

Comment 8

[Dimi Lee [:dimi][:dlee]]

(In reply to :ehsan akhgari from comment #7)

Can these changes land now?

Yes, Bug 1601660 was landed two days ago, we can land this one now :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/805fb67be8a3
P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/2bc0fa3bbe0e
P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/2e165c119a4f
P3. Remove unused IPC method in nsIParentChannel.idl. r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/721f54870498
P4. Report content blocking log to console while running in the parent process r=Ehsan

Comment 10

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1599046) for xpcshell failures at test_ext_cookieBehaviors.
https://hg.mozilla.org/integration/autoland/rev/549b175a1e00e22692ced2d47de30172b9fab779

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=721f54870498640c476fbd16d232f78afe84f782&selectedJob=286592368

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286592368&repo=autoland&lineNumber=2188

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db8e34b8d16c
P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/cb08405e4cbc
P2. Remove calling NotifyOnContentBlocking in the child process r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/4feab5c36c60
P3. Remove unused IPC method in nsIParentChannel.idl. r=timhuang,Ehsan
https://hg.mozilla.org/integration/autoland/rev/dcc985749140
P4. Report content blocking log to console while running in the parent process r=Ehsan

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/db8e34b8d16c
https://hg.mozilla.org/mozilla-central/rev/cb08405e4cbc
https://hg.mozilla.org/mozilla-central/rev/4feab5c36c60
https://hg.mozilla.org/mozilla-central/rev/dcc985749140

Comment 13

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24812 (as of Tue, 28 Jan 2020 20:33:25 GMT) ==

Improvements:

6% raptor-tp6-instagram-firefox-cold loadtime windows10-64-shippable opt 1,419.83 -> 1,330.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24812