1601660 - Make GeckoView get content blocking log from the parent process

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Dimi Lee [ooo 16.04 - 21.04］]

GeckoView accesses content blocking log here via docshell.getContentBlockingLog.

There are two approaches we can take to make this anti-tracking fission compatible:

1. Add a IPC message from the child to the parent to get the log.
2. GeckoView gets content blocking log directly from the parent.

The better way would be #2 because the log is already in the parent process, so we don't have to involve an IPC call. If #2 is not doable, then we will use #1 approach.

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Dylan, needinfo you since you implemented Bug 1580201
We are current moving content blocking log from the child process to the parent process to make anti-tracking fission compatiable. APIs that access content blocking log also need to update accordingly. One thing related to geckoview is the use case here

My question is, for this use case, can GeckoView access ContentBlockingLog directly from the parent process through WindowGlobalParent(will be implemented in Bug 1599043). If not, I'll fix this with approach #1., thx

Comment 2

[Dylan Roeh (:droeh) (he/him)]

(In reply to Dimi Lee [:dimi][:dlee] from comment #1)

Dylan, needinfo you since you implemented Bug 1580201
We are current moving content blocking log from the child process to the parent process to make anti-tracking fission compatiable. APIs that access content blocking log also need to update accordingly. One thing related to geckoview is the use case here

My question is, for this use case, can GeckoView access ContentBlockingLog directly from the parent process through WindowGlobalParent(will be implemented in Bug 1599043). If not, I'll fix this with approach #1., thx

Yes, I think we can get the WindowGlobalParent in parent process js -- it will probably actually be an improvement over our current implementation.

Comment 3

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: code removal.patch

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 1601660 - Part 2: Remove getContentBlockingLog from nsIDocShell.idl

Depends on D56737

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1601660 - Part 1: Make GeckoView to get the content blocking log in the parent process.

This patch is doing two things.

1. Make GeckoView directly gets the ContentBlockingLog in the parent
   process when it gets the bundle event 'ContentBlocking:RequestLog'. It
   will get the top-level browsingContext and get the log from the
   WindowGlobal of this browsingContext.
2. Remove the GeckoViewContentBlockingChild. The child module of
   ContentBlocking is no longer needed since it serves nothing after we move
   the functionality of getting log to the parent process.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06001b30f6cd
Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp
https://hg.mozilla.org/integration/autoland/rev/ec5d3b078a88
Part 2: Remove getContentBlockingLog from nsIDocShell.idl r=Ehsan

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2677d8ef770
Backed out 2 changesets for gv-junit failures in ContentBlockingControllerTest. on a CLOSED TREE

Comment 8

[Oana Pop-Rus]

Backed out 2 changesets (bug 1601660) for gv-junit failures in ContentBlockingControllerTest

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=ec5d3b078a88d9733b5a1d82ccc24360811baf65&selectedJob=285929897

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285929897&repo=autoland&lineNumber=1476

Backout: https://hg.mozilla.org/integration/autoland/rev/e2677d8ef7700cb4b023a64be2dae32145d57329

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/970c96636f40
Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp
https://hg.mozilla.org/integration/autoland/rev/ebff6fae285e
Part 2: Remove getContentBlockingLog from nsIDocShell.idl r=Ehsan

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcd450deb288
Fix lint failure r=fix CLOSED TREE

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/970c96636f40
https://hg.mozilla.org/mozilla-central/rev/ebff6fae285e
https://hg.mozilla.org/mozilla-central/rev/bcd450deb288

Comment 12

[Chris Peterson [:cpeterson]]

Move GeckoView::Tracking Protection bugs to the GeckoView::General component.