Closed Bug 1599324 Opened 12 days ago Closed 10 days ago

Popup doesn't appear in the center, can't scroll to click the buttons

Categories

(Core :: CSS Parsing and Computation, defect)

72 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- fixed

People

(Reporter: karlcow, Assigned: emilio)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

This was reported by Panos and this is a regression because of the zoom hack attempt.

Basically the issue is with this part of the CSS rule. I cut the rest for brevity.

.modal.modal--show .modal-container {

	transform: translate(-50%,-50%);
	zoom: 1;
}

Applying the zoom with the transform cancels the effect of the transform: translate(-50%,-50%); and breaks the design on the site.

People do like to use zoom along with transforms for legit reasons, which means
that we get this wrong.

This is unfortunate, as the whole point of the hack was fixing sites that only
used zoom without regressing sites that would do:

zoom: 0.5;
-moz-transform: scale(0.5);
transform-origin: 0 0;

So we're a bit stuck here. The only way to deal with the known regressions is
parsing zoom: 1 as invalid, which is insane, and it would probably cause other
compat issues... For now disable the pref.

Assignee: nobody → emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c10d8e6c8a4
Disable layout.css.zoom-transform-hack.enabled for now. r=boris

And clean-up surrounding code by removing useless namespace qualification.

It seems like the first call to Broadcast is useless? Or am I missing something?

Comment on attachment 9112045 [details]
Bug 1599324 - Make one variant of BlobURLProtocolHandler::AddDataEntry infallible. r=baku

Revision D55000 was moved to bug 1599843. Setting attachment 9112045 [details] to obsolete.

Attachment #9112045 - Attachment is obsolete: true

When zoom is disabled, we still count it, but with the current code the testing
function will throw instead of returning the right value, which means we'd fail
layout/style/test/test_use_counters.html.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f942560109f
Fix Servo_IsCssPropertyRecordedInUseCounter so that we also report disabled properties. r=boris
Attachment #9111517 - Attachment description: Bug 1599324 - Disable layout.css.zoom-transform-hack.enabled for now. → Bug 1599324 - Disable layout.css.zoom-transform-hack.enabled for now. r=boris
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/461d07650b52
Disable layout.css.zoom-transform-hack.enabled for now. r=boris
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.