Level 2 (Strict) List cookies are not being blocked after restart and load tracker immediately
Categories
(Core :: Privacy: Anti-Tracking, defect)
Tracking
()
People
(Reporter: sbadau, Assigned: dimi)
References
Details
Attachments
(2 files)
9.89 MB,
video/mp4
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0
Build ID: 20191125214644
Affected versions:
- Nightly 72.0a1
Affected platforms:
- Ubuntu 18.04 x64
- Windows 10
- Mac OS X 10.14
Steps to reproduce:
- Open Firefox
- Navigate to: https://senglehardt.com/test/trackingprotection/test_pages/tracking_protection.html
- Look at the "Level 2 (Strict) List" section at the bottom of the page.
- Click on the Shield icon and turn ETP off
- Click again on the Shield icon turn ETP back on
- Restart Firefox (used keyboard combination: Ctrl+Shift+J and after Ctrl+Alt+R)
- Look at the "Level 2 (Strict) List" section at the bottom of the page.
Actual results:
After the restart, the message "Cookies not blocked" is displayed.
Expected results:
After the restart, the displayed message should be "Cookies BLOCKED".
Comment 1•5 years ago
|
||
This looks very similar to bug 1599137, in one case you restart the browser before an update, in the other case you just reload the page after changing settings...
I wonder if they somehow have the same underlying cause? Dimi, do you mind having a look at this one too? Setting a dependency for now...
Assignee | ||
Comment 2•5 years ago
|
||
This looks like a timing issue when you launch Firefox with page with trackers.
I can reproduce this without turning ETP on/off.
Assignee | ||
Comment 3•5 years ago
|
||
There are two places using DBService during a page load at startup:
- nsChannelClassifier::Start, used by Phishing Protection
- AsyncChannelClassifier::CheckChannel, used by Tracking Protection
Tracking protection checks happen before establishing a network connection, so it happens
prior to phishing protection checkes. When we load a page at
startup, ::CheckChannel API is called, but DBService is not yet created.
This patch fixes this issue by creating a DBService instance when
::GetWorker API is called without a DBService instance.
Assignee | ||
Updated•5 years ago
|
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecc4010a247c Create a DBService instance in GetWorker API when it doesn't exist. r=baku
Comment 5•5 years ago
|
||
Backed out changeset ecc4010a247c (bug 1599379) for causing bustages
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=279017478&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ecc4010a247c0f439bf01b33644d822956f16028
backout: https://hg.mozilla.org/integration/autoland/rev/3a7b90a6ba2cc27dd87d4d809d5e400edc58c6ac
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42913f0f886d Create a DBService instance in GetWorker API when it doesn't exist. r=baku
Comment 7•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 9•5 years ago
|
||
Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0
Verified as fixed using the latest Nightly 73.0a1 on Windows 10 x64, Mac OS X 10.14 and Ubuntu 18.06 x64.
Assignee | ||
Comment 10•5 years ago
|
||
Comment on attachment 9112487 [details]
Bug 1599379 - Create a DBService instance in GetWorker API when it doesn't exist. r?baku
Beta/Release Uplift Approval Request
- User impact if declined: Tracking protection related features don't work for the first few loads (number of loads affected is related to the timing).
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See bug description to reproduce this bug
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch only advances the timing we create URL Classifier worker thread, it doesn't change the logic that how we classify trackers.
- String changes made/needed: None
Assignee | ||
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Comment on attachment 9112487 [details]
Bug 1599379 - Create a DBService instance in GetWorker API when it doesn't exist. r?baku
tracking protection fix, verified in nightly, approved for 72.0b5
Comment 12•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Reporter | ||
Comment 13•5 years ago
|
||
Verified as fixed on Firefox 72 beta 5 - tested on Mac OS X 10.14, Ubuntu 18.04 x64, Windows 10 x64 and Windows 7.
Reporter | ||
Updated•5 years ago
|
Description
•