Closed Bug 1599574 Opened 5 years ago Closed 3 years ago

--enable-clang plugin builds always rebuild the clang-plugin tests.

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement, P4)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mgaudet, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1599574 - Avoid re-running clang-plugin tests.
48 bytes, text/x-phabricator-request
Details | Review

After Bug 1586100 we can build stand alone SpiderMonkey with the clang-plugin enabled:

STR:

  1. mkdir js/src/build_clang_format_DBG.OBJ; cd js/src/build_clang_format_DBG.OBJ
  2. ../configure --enable-clang-plugin
  3. make: Build succeeds.
  4. make: Actual: Build system rebuilds the tests. Expected: Build completes without any more compiler invocations.
Summary: --enable-clang plugin Spidermonkey builds always rebuild the clang-plugin tests. → --enable-clang plugin builds always rebuild the clang-plugin tests.
Priority: -- → P4

I don't think I've actually noticed this recently. I think it may have been fixed without this bug.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: nobody → mh+mozilla
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5b5e4fe1aa71
Avoid re-running clang-plugin tests. r=firefox-build-system-reviewers,andi,mhentges

https://hg.mozilla.org/mozilla-central/rev/5b5e4fe1aa71

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: