1599778 - Info message text visible on top of main panel content while it fades out

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:

1. Open the info message in the protections panel
2. Click the "i" button to close it and observe the text closely.

As the rest of the panel content slides up, it doesn't cover up the text, which stays on top in the layout. The issue is masked due to the opacity decreasing to zero while the panel moves up.

Removing the opacity: 0 rule shows that the text is actually on top of the rest of the panel content. This is solved by setting overflow: hidden on the header container (protections-popup-mainView-panel-header-section).

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Erica, do you have time to make a patch for this? I tested the fix I mentioned above using the inspector and it seems straightforward. If not, I can look into it tomorrow. Maybe we can get it into 71, but probably not a big deal if we don't.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Screenshot

Here's what it looks like mid-animation.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

This is way more visible with the dark theme, since in the light theme the panel background and the text are both white.

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1599778 - Info message fades below the main content panel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67de5253f91c
Info message fades below the main content panel. r=nhnt11

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/67de5253f91c

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 72.0a1 (2019-11-27) on Windows 10, 64 Bit. The fix of this bug is now verified on latest Nightly 73.0a1!

Build ID : 20191216214733
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0