1601051 - Navigating with the Tab key in the protections panel makes its header's content to disappear

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Itiel]

Attachment: Screenshot

STR:

1. Go to any website
2. Open the protections panel on the urlbar
3. Tab once -- the (i) button is focused
4. Tab once more -- an invisible element is focused and the header's contents ("Protections for <domain>" and the (i) button) are gone

I'm also seeing flickering on some clicks on the (i) button, but not sure if that is a regression (if at all) from the same bug.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1601051 - Navigating with the Tab key can select the learn more link only when visible.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2ce013628be
Navigating with the Tab key can select the learn more link only when visible. r=nhnt11

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b2ce013628be

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval. It grafts cleanly as-landed.

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9118576 [details]
Bug 1601051 - Navigating with the Tab key can select the learn more link only when visible.

Beta/Release Uplift Approval Request

• User impact if declined: Users navigating in the protections panel by using the tab key select an invisible element and the UI responds poorly. This correctly disables the element, and ensures keyboard users can select the element when it is enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1609248
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small JS patch. Test test coverage for the listener is in the related patch, 1609248
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9118576 [details]
Bug 1601051 - Navigating with the Tab key can select the learn more link only when visible.

Fix for keyboard-only users. Approved for 73.0b6. Please also uplift bug 1609248 as a test-only followup to this bug.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e42d01b594e8

Comment 8

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue using an affected Nightly build from 2019-19-03.

The issue is verified fixed on Beta 73.0b6 across platforms: Win 10 x64, maOS 10.13 and Ubuntu 16.04 x86.