1599806 - Refactor accessibility actor to no use setupInParent.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, task, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

We can't use setupInParent with fission as it relies on message managers. Instead we are going to create an accessibility actor in parent process that will deal with all the functionality that requires parent process.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1599806 - remove setupInParent from accessibility actor and split up child/parent functionality into two separate actors. r=rcaliman,ochameau

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1599806 - Move accessible walker creation into accessibility front's bootsrap method. Do not explicitly destroy accessibility walker front and let accessibility actor manage its lifecycle fully. r=ochameau, jdescottes

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1599806 - introduce accessibility proxy that would be responsible for interacting with panel's UI instead of directly referencing accessibility related fronts. r=rcaliman

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1599806 - remove setupInParent from accessibility actor and split up child/parent functionality into two separate actors. r=rcaliman,ochameau

Depends on D58806

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1599806 - update accessibility actors tests to support parent accessibility actor. r=rcaliman,ochameau

Depends on D58807

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7563b0c41886
avoid AccessibilityFront's bootstrap method by renaming it into initialize. Do not explicitly destroy accessibility walker front and let accessibility actor manage its lifecycle fully. r=ochameau

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1599806, Bug 1604594, Bug 1605435) for causing devtools failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=288244542&resultStatus=testfailed%2Cbusted%2Cexception&revision=b3b92ce56bbd9c3af13ffe23252e110d9791fc1d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244542&repo=autoland&lineNumber=1828
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244801&repo=autoland&lineNumber=1114
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244529&repo=autoland&lineNumber=1659

Backout: https://hg.mozilla.org/integration/autoland/rev/567ff72d71662e200541d1afbe69a19b8c442ac1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67ebdce37d58
Move accessible walker creation into accessibility front's bootsrap method. Do not explicitly destroy accessibility walker front and let accessibility actor manage its lifecycle fully. r=ochameau,jdescottes

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/67ebdce37d58

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a31f55cec08
introduce accessibility proxy that would be responsible for interacting with panel's UI instead of directly referencing accessibility related fronts. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/2430d82847ef
remove setupInParent from accessibility actor and split up child/parent functionality into two separate actors. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/643f78f84dd0
update accessibility actors tests to support parent accessibility actor. r=ochameau

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0a31f55cec08
https://hg.mozilla.org/mozilla-central/rev/2430d82847ef
https://hg.mozilla.org/mozilla-central/rev/643f78f84dd0