1604594 - Decouple accessibility walker from the client code as much as possible.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, task, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now we are passing accessibility walker to too many components and methods. Instead we should avoid references to a top level accessibility walker wherever possible since in many cases there will be no guarantee that the accessible fronts will belong to it.

There are a couple of places (particularly where we add event listeners to the walker) where we can't just avoid having a walker and instead, in the future would have to add (dynamically) listeners to all walkers that are created for various targets.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - decouple picker from accessibility walker front. r=rcaliman

Depends on D58027

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman

Depends on D58028

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - decouple accessibility walker front from the accessibility tree component. r=rcaliman

Depends on D58029

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - decouple accessibility walker front from the MainFrame component. r=rcaliman

Depends on D58030

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - decouple accessibility walker front from the audit redux action. r=rcaliman

Depends on D58031

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1604594 - make accessibility walker front naming consistent across client. r=rcaliman

Depends on D58032

Comment 7

[Chris Peterson [:cpeterson]]

Tracking DevTools bugs for Fission Nightly (M6) milestone

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b679985b1d
decouple picker from accessibility walker front. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/1ec5fbe50915
do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/e9dd08e86da5
decouple accessibility walker front from the accessibility tree component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/2125bbef0588
decouple accessibility walker front from the MainFrame component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/9ed06bf20923
decouple accessibility walker front from the audit redux action. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/1a125601a5d0
make accessibility walker front naming consistent across client. r=rcaliman

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1599806, Bug 1604594, Bug 1605435) for causing devtools failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=288244542&resultStatus=testfailed%2Cbusted%2Cexception&revision=b3b92ce56bbd9c3af13ffe23252e110d9791fc1d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244542&repo=autoland&lineNumber=1828
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244801&repo=autoland&lineNumber=1114
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244529&repo=autoland&lineNumber=1659

Backout: https://hg.mozilla.org/integration/autoland/rev/567ff72d71662e200541d1afbe69a19b8c442ac1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/391271e9ad89
decouple picker from accessibility walker front. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/6f00a753bb76
do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/821540954b36
decouple accessibility walker front from the accessibility tree component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/7ca11e8e8c11
decouple accessibility walker front from the MainFrame component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/6b29e01a852e
decouple accessibility walker front from the audit redux action. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/e2a479bc29b4
make accessibility walker front naming consistent across client. r=rcaliman

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/391271e9ad89
https://hg.mozilla.org/mozilla-central/rev/6f00a753bb76
https://hg.mozilla.org/mozilla-central/rev/821540954b36
https://hg.mozilla.org/mozilla-central/rev/7ca11e8e8c11
https://hg.mozilla.org/mozilla-central/rev/6b29e01a852e
https://hg.mozilla.org/mozilla-central/rev/e2a479bc29b4