Closed Bug 1604594 Opened 2 years ago Closed 2 years ago

Decouple accessibility walker from the client code as much as possible.

Categories

(DevTools :: Accessibility Tools, task, P1)

task

Tracking

(Fission Milestone:M6, firefox75 fixed)

RESOLVED FIXED
Firefox 75
Fission Milestone M6
Tracking Status
firefox75 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Whiteboard: dt-fission-m2-reserve)

Attachments

(6 files)

Right now we are passing accessibility walker to too many components and methods. Instead we should avoid references to a top level accessibility walker wherever possible since in many cases there will be no guarantee that the accessible fronts will belong to it.

There are a couple of places (particularly where we add event listeners to the walker) where we can't just avoid having a walker and instead, in the future would have to add (dynamically) listeners to all walkers that are created for various targets.

Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Whiteboard: dt-fission-m2-mvp
Priority: -- → P1
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-mvp

Tracking DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/36b679985b1d
decouple picker from accessibility walker front. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/1ec5fbe50915
do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/e9dd08e86da5
decouple accessibility walker front from the accessibility tree component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/2125bbef0588
decouple accessibility walker front from the MainFrame component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/9ed06bf20923
decouple accessibility walker front from the audit redux action. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/1a125601a5d0
make accessibility walker front naming consistent across client. r=rcaliman
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/391271e9ad89
decouple picker from accessibility walker front. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/6f00a753bb76
do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/821540954b36
decouple accessibility walker front from the accessibility tree component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/7ca11e8e8c11
decouple accessibility walker front from the MainFrame component. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/6b29e01a852e
decouple accessibility walker front from the audit redux action. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/e2a479bc29b4
make accessibility walker front naming consistent across client. r=rcaliman
Flags: needinfo?(yzenevich)
You need to log in before you can comment on or make changes to this bug.