1599887 - [Windows] PiP (Picture in Picture) -> Crash Report [@ OOM | small ] / Process Type = gpu / Crash Reason = EXCEPTION_BREAKPOINT

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[MrX1980]

Firefox 71.0+ has a OOM bug. Could be a blocker for the Firefox 71 release (2019-12-03).

Steps to repcroduce:
a) start Firefox 71.0rc2 (64-bit) or higher
b) start a video with Picture in Picture support (examples below)
c) click on the PiP symbol to activate the PiP function
d) look at Task Manager -> Performance -> GPU & Memory = The GPU memory usage will increase until it is full. After the GPU memory is full, the RAM memory usage will increase. After some seconds Windows 10 will start to compress the data, that is in the RAM, until it reaches ~1 to 2 GB compressed RAM.
e) The Firefox PiP tab or dwm.exe (Desktop Windows Manager) will be crashing. Not always will be a crash report created. Sometimes the video will start from the begining or the PiP tab will be black (video and audio stopping).

The same videos without PiP mode are running fine.

example urls:
https://www.ardmediathek.de
https://www.zdf.de
(start one the the videos)

---

Quelle
Desktop Window Manager

Zusammenfassung
Nicht mehr funktionsfähig

Datum
‎27.‎11.‎2019 19:10

Status
Der Bericht wurde gesendet.

Beschreibung
Pfad der fehlerhaften Anwendung: C:\Windows\System32\dwm.exe

Problemsignatur
Problemereignisame: APPCRASH
Anwendungsname: dwm.exe
Anwendungsversion: 10.0.19033.1
Anwendungszeitstempel: 9a82ecd2
Fehlermodulname: KERNELBASE.dll
Fehlermodulversion: 10.0.19033.1
Fehlermodulzeitstempel: e3086bea
Ausnahmecode: c00001ad
Ausnahmeoffset: 000000000010b4dc
Betriebsystemversion: 10.0.19033.2.0.0.256.48
Gebietsschema-ID: 1031
Zusatzinformation 1: d585
Zusatzinformation 2: d5854abc9eecd740d3fd0b999e4d6a10
Zusatzinformation 3: c935
Zusatzinformation 4: c9355f977ba703f0e654dd8a0be26b0b

Weitere Informationen über das Problem
Bucket-ID: de57744097824b758bc08fc431b04e0f (1999756307362500111)

Comment 1

[MrX1980]

Attachment: GPU_usage_increase.jpg

Comment 2

[MrX1980]

Attachment: RAM_usage_increase.jpg

Comment 3

[MrX1980]

Attachment: PiP-tab_crashed.jpg

Comment 4

[Andreas Pehrson [:pehrsons]]

Moving to the component for picture-in-picture-specific bugs.

Comment 5

[MrX1980]

I have done some more tests with different devices/settings and have now more information's for you.
First I need to add one more step to the STR list. Between step c) and d) there need to be "minimize the (main) Firefox window". Only when the Firefox window is minimized, the memory increase will start.
Second, if I set gfx.webrender.force-disabled=true or on devices, where WebRender is not enabled by default, the problem does not occur. So it seems to be a WebRender related bug.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

I can reproduce this fairly easily on my Windows box with WebRender enabled using the STR from comment 1 when the Firefox main window is minimized.

Hey Gankra, this looks to be WebRender related... do you know who'd be best on your team to help us figure out what's going on?

Comment 8

[Aria Beingessner [:Gankra]]

Attachment: about-support-no-problem.txt

Could y'all provide your about:support's and describe your monitor setup? I can't seem to reproduce this on my laptop and it isn't clear what the variable is.

Comment 9

[MrX1980]

Attachment: Firefox71_about_support.txt

Here are the requested information's.

Comment 10

[MrX1980]

Attachment: DxDiag_MainPC_Win10_19033_2019-12-02.txt

Comment 11

[MrX1980]

Attachment: Win10_Settings_Display.PNG

Comment 12

[MrX1980]

Attachment: Firefox71_about_support_2ndPC.txt

2nd PC with single monitor.

Comment 13

[MrX1980]

Attachment: DxDiag_SecondPC_Win10_19033_2019-12-02.txt

Comment 14

[Mike Conley (:mconley) (:⚙️)]

I'm able to get what appears to be a leak if I'm looking at a 4K video, for example, https://www.youtube.com/watch?v=Bey4XXJAqS8 at highest quality.

Still trying to determine if I get that leak at lower quality settings.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

When watching that same video at lower quality, memory climbs a bit and then drops back down all at once, probably from a GC.

Comment 16

[Aria Beingessner [:Gankra]]

So just to summarize findings: when this is happening our AsyncImagePipelineManager has an mTextureHostsUntilRenderCompleted that keeps growing in size indefinitely. So we're seemingly not getting a chance to release any of our video frames. This suggests that WR (or something inbetween) is failing to report new epochs while the window is minimized.

Normally this isn't a big issue because a minimized window doesn't have much rendering to do, but PiP makes it easy to introduce a visible video with a minimized browser. That said, mconley did say he was able to reproduce it without PiP but it does make it easier.

I'll investigate this tomorrow.

Comment 17

[Sergey Ivanov]

Application Basics

Name: Firefox
Version: 70.0.1
Build ID: 20191030021342
Update Channel: release
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
OS: Windows_NT 10.0
Launcher Process: Enabled
Multiprocess Windows: 1/1 Enabled by default
Remote Processes: 10
Enterprise Policies: Inactive
Google Location Service Key: Found
Google Safebrowsing Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Crash Reports for the Last 3 Days

Firefox Features

Name: Firefox Screenshots
Version: 39.0.0
ID: [e-mail]

Name: Form Autofill
Version: 1.0
ID: [e-mail]

Name: Web Compat
Version: 6.2.0
ID: [e-mail]

Name: WebCompat Reporter
Version: 1.1.0
ID: [e-mail]

Remote Processes

Type: Web Content
Count: 8 / 8

Type: Extension
Count: 1

Type: GPU
Count: 1

Extensions

Name: Amazon.com
Version: 1.1
Enabled: true
ID: [e-mail]

Name: Bing
Version: 1.0
Enabled: true
ID: [e-mail]

Name: Checker Plus for Gmail
Version: 21.5.9
Enabled: true
ID: [e-mail]

Name: DuckDuckGo
Version: 1.0
Enabled: true
ID: [e-mail]

Name: DuckDuckGo Privacy Essentials
Version: 2019.9.12
Enabled: true
ID: jid1-ZAdIEUB7XOzOJw@jetpack

Name: Enhancer for YouTube™
Version: 2.0.98.2
Enabled: true
ID: [e-mail]

Name: Google
Version: 1.0
Enabled: true
ID: [e-mail]

Name: iMacros for Firefox
Version: 10.0.2.1450
Enabled: true
ID: {81BF1D23-5F17-408D-AC6B-BD6DF7CAF670}

Name: Image saver
Version: 0.6
Enabled: true
ID: {ef406867-8dfe-4bed-8ec7-f48785cdcae9}

Name: Iridium for YouTube
Version: 1.2.4
Enabled: true
ID: [e-mail]

Name: Search by Image
Version: 1.22.0
Enabled: true
ID: {2e5ff8c8-32fe-46d0-9fc8-6b8986621f3c}

Name: Twitter
Version: 1.0
Enabled: true
ID: [e-mail]

Name: uBlock Origin
Version: 1.24.2
Enabled: true
ID: [e-mail]

Name: Video Speed Controller
Version: 0.5.1
Enabled: true
ID: {7be2ba16-0f1e-4d93-9ebc-5164397477a9}

Name: Wikipedia (en)
Version: 1.0
Enabled: true
ID: [e-mail]

Name: Windscribe - Free Proxy and Ad Blocker
Version: 3.0.37
Enabled: true
ID: @windscribeff

Name: AliTools shopping assistant
Version: 19.11.4.7755
Enabled: false
ID: {019f5290-6afb-4863-bc31-87cc0b6adb25}

Name: Cashback service LetyShops
Version: 2.5.36
Enabled: false
ID: cashback_letyshops@LetyShops

Name: Chrome Store Foxified
Version: 3.4
Enabled: false
ID: Chrome-Store-Foxified@jetpack

Name: Dark Reader
Version: 4.8.5
Enabled: false
ID: [e-mail]

Name: FastProxy - Россия
Version: 2.0.6
Enabled: false
ID: {4bf7c817-a8ab-4d98-b84d-65f79f05415d}

Name: FoxyProxy Standard
Version: 7.4.1
Enabled: false
ID: [e-mail]

Name: SiteMacro
Version: 0.5
Enabled: false
ID: {100afed2-637a-46b0-bc60-38d1f90a5d72}

Name: User-Agent Switcher
Version: 1.3.18
Enabled: false
ID: [e-mail]

Security Software

Type:

Type:

Type:

Graphics

Features
Compositing: WebRender
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
WebGL 1 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000bc41) EGL_VERSION: 1.4 (ANGLE 2.1.0.21dccd386996) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_ANDROID_blob_cache EGL_ANDROID_recordable EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context
WebGL 1 Driver Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GTX 1070 Ti Direct3D11 vs_5_0 ps_5_0)
WebGL 1 Driver Version: OpenGL ES 2.0 (ANGLE 2.1.0.21dccd386996)
WebGL 1 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_memory_size GL_ANGLE_multi_draw GL_ANGLE_multiview_multisample GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_provoking_vertex GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_func_extended GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_float_blend GL_EXT_frag_depth GL_EXT_instanced_arrays GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_bptc GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_border_clamp GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_disjoint_timer_query EXT_float_blend EXT_frag_depth EXT_shader_texture_lod EXT_sRGB EXT_texture_compression_bptc EXT_texture_filter_anisotropic OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000bc41) EGL_VERSION: 1.4 (ANGLE 2.1.0.21dccd386996) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_ANDROID_blob_cache EGL_ANDROID_recordable EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context
WebGL 2 Driver Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GTX 1070 Ti Direct3D11 vs_5_0 ps_5_0)
WebGL 2 Driver Version: OpenGL ES 3.0 (ANGLE 2.1.0.21dccd386996)
WebGL 2 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_copy_texture_3d GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_memory_size GL_ANGLE_multi_draw GL_ANGLE_multiview_multisample GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_provoking_vertex GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_multisample GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_func_extended GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_float_blend GL_EXT_frag_depth GL_EXT_instanced_arrays GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_bptc GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_border_clamp GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object GL_OVR_multiview2 OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture
WebGL 2 Extensions: EXT_color_buffer_float EXT_disjoint_timer_query EXT_float_blend EXT_texture_compression_bptc EXT_texture_filter_anisotropic OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
Direct2D: true
Uses Tiling (Content): true
Off Main Thread Painting Enabled: true
Off Main Thread Painting Worker Count: 4
Target Frame Rate: 60
DirectWrite: true (10.0.17763.1)
GPU #1
Active: Yes
Description: NVIDIA GeForce GTX 1070 Ti
Vendor ID: 0x10de
Device ID: 0x1b82
Driver Version: 26.21.14.4108
Driver Date: 10-22-2019
Drivers: C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumdx.dll C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_71164464ccd46ae5\nvldumd.dll
Subsys ID: 37921458
RAM: 8192

Diagnostics
AzureCanvasBackend: direct2d 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: skia
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): none
CMSOutputProfile: AAAMSExpbm8CEAAAbW50clJHQiBYWVogB84AAgAJAAYAMQAAYWNzcE1TRlQAAAAASUVDIHNSR0IAAAAAAAAAAAAAAAAAAPbWAAEAAAAA0y1IUCAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAARY3BydAAAAVAAAAAzZGVzYwAAAYQAAABsd3RwdAAAAfAAAAAUYmtwdAAAAgQAAAAUclhZWgAAAhgAAAAUZ1hZWgAAAiwAAAAUYlhZWgAAAkAAAAAUZG1uZAAAAlQAAABwZG1kZAAAAsQAAACIdnVlZAAAA0wAAACGdmlldwAAA9QAAAAkbHVtaQAAA/gAAAAUbWVhcwAABAwAAAAkdGVjaAAABDAAAAAMclRSQwAABDwAAAgMZ1RSQwAABDwAAAgMYlRSQwAABDwAAAgMdGV4dAAAAABDb3B5cmlnaHQgKGMpIDE5OTggSGV3bGV0dC1QYWNrYXJkIENvbXBhbnkAAGRlc2MAAAAAAAAAEnNSR0IgSUVDNjE5NjYtMi4xAAAAAAAAAAAAAAASc1JHQiBJRUM2MTk2Ni0yLjEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFhZWiAAAAAAAADzUQABAAAAARbMWFlaIAAAAAAAAAAAAAAAAAAAAABYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9kZXNjAAAAAAAAABZJRUMgaHR0cDovL3d3dy5pZWMuY2gAAAAAAAAAAAAAABZJRUMgaHR0cDovL3d3dy5pZWMuY2gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAZGVzYwAAAAAAAAAuSUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJHQiBjb2xvdXIgc3BhY2UgLSBzUkdCAAAAAAAAAAAAAAAuSUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJHQiBjb2xvdXIgc3BhY2UgLSBzUkdCAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGRlc2MAAAAAAAAALFJlZmVyZW5jZSBWaWV3aW5nIENvbmRpdGlvbiBpbiBJRUM2MTk2Ni0yLjEAAAAAAAAAAAAAACxSZWZlcmVuY2UgVmlld2luZyBDb25kaXRpb24gaW4gSUVDNjE5NjYtMi4xAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB2aWV3AAAAAAATpP4AFF8uABDPFAAD7cwABBMLAANcngAAAAFYWVogAAAAAABMCVYAUAAAAFcf521lYXMAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAKPAAAAAnNpZyAAAAAAQ1JUIGN1cnYAAAAAAAAEAAAAAAUACgAPABQAGQAeACMAKAAtADIANwA7AEAARQBKAE8AVABZAF4AYwBoAG0AcgB3AHwAgQCGAIsAkACVAJoAnwCkAKkArgCyALcAvADBAMYAywDQANUA2wDgAOUA6wDwAPYA+wEBAQcBDQETARkBHwElASsBMgE4AT4BRQFMAVIBWQFgAWcBbgF1AXwBgwGLAZIBmgGhAakBsQG5AcEByQHRAdkB4QHpAfIB+gIDAgwCFAIdAiYCLwI4AkECSwJUAl0CZwJxAnoChAKOApgCogKsArYCwQLLAtUC4ALrAvUDAAMLAxYDIQMtAzgDQwNPA1oDZgNyA34DigOWA6IDrgO6A8cD0wPgA+wD+QQGBBMEIAQtBDsESARVBGMEcQR+BIwEmgSoBLYExATTBOEE8AT+BQ0FHAUrBToFSQVYBWcFdwWGBZYFpgW1BcUF1QXlBfYGBgYWBicGNwZIBlkGagZ7BowGnQavBsAG0QbjBvUHBwcZBysHPQdPB2EHdAeGB5kHrAe/B9IH5Qf4CAsIHwgyCEYIWghuCIIIlgiqCL4I0gjnCPsJEAklCToJTwlkCXkJjwmkCboJzwnlCfsKEQonCj0KVApqCoEKmAquCsUK3ArzCwsLIgs5C1ELaQuAC5gLsAvIC+EL+QwSDCoMQwxcDHUMjgynDMAM2QzzDQ0NJg1ADVoNdA2ODakNww3eDfgOEw4uDkkOZA5/DpsOtg7SDu4PCQ8lD0EPXg96D5YPsw/PD+wQCRAmEEMQYRB+EJsQuRDXEPURExExEU8RbRGMEaoRyRHoEgcSJhJFEmQShBKjEsMS4xMDEyMTQxNjE4MTpBPFE+UUBhQnFEkUahSLFK0UzhTwFRIVNBVWFXgVmxW9FeAWAxYmFkkWbBaPFrIW1hb6Fx0XQRdlF4kXrhfSF/cYGxhAGGUYihivGNUY+hkgGUUZaxmRGbcZ3RoEGioaURp3Gp4axRrsGxQbOxtjG4obshvaHAIcKhxSHHscoxzMHPUdHh1HHXAdmR3DHeweFh5AHmoelB6+HukfEx8+H2kflB+/H+ogFSBBIGwgmCDEIPAhHCFIIXUhoSHOIfsiJyJVIoIiryLdIwojOCNmI5QjwiPwJB8kTSR8JKsk2iUJJTglaCWXJccl9yYnJlcmhya3JugnGCdJJ3onqyfcKA0oPyhxKKIo1CkGKTgpaymdKdAqAio1KmgqmyrPKwIrNitpK50r0SwFLDksbiyiLNctDC1BLXYtqy3hLhYuTC6CLrcu7i8kL1ovkS/HL/4wNTBsMKQw2zESMUoxgjG6MfIyKjJjMpsy1DMNM0YzfzO4M/E0KzRlNJ402DUTNU01hzXCNf02NzZyNq426TckN2A3nDfXOBQ4UDiMOMg5BTlCOX85vDn5OjY6dDqyOu87LTtrO6o76DwnPGU8pDzjPSI9YT2hPeA+ID5gPqA+4D8hP2E/oj/iQCNAZECmQOdBKUFqQaxB7kIwQnJCtUL3QzpDfUPARANER0SKRM5FEkVVRZpF3kYiRmdGq0bwRzVHe0fASAVIS0iRSNdJHUljSalJ8Eo3Sn1KxEsMS1NLmkviTCpMcky6TQJNSk2TTdxOJU5uTrdPAE9JT5NP3VAnUHFQu1EGUVBRm1HmUjFSfFLHUxNTX1OqU/ZUQlSPVNtVKFV1VcJWD1ZcVqlW91dEV5JX4FgvWH1Yy1kaWWlZuFoHWlZaplr1W0VblVvlXDVchlzWXSddeF3JXhpebF69Xw9fYV+zYAVgV2CqYPxhT2GiYfViSWKcYvBjQ2OXY+tkQGSUZOllPWWSZedmPWaSZuhnPWeTZ+loP2iWaOxpQ2maafFqSGqfavdrT2una/9sV2yvbQhtYG25bhJua27Ebx5veG/RcCtwhnDgcTpxlXHwcktypnMBc11zuHQUdHB0zHUodYV14XY+dpt2+HdWd7N4EXhueMx5KnmJeed6RnqlewR7Y3vCfCF8gXzhfUF9oX4BfmJ+wn8jf4R/5YBHgKiBCoFrgc2CMIKSgvSDV4O6hB2EgITjhUeFq4YOhnKG14c7h5+IBIhpiM6JM4mZif6KZIrKizCLlov8jGOMyo0xjZiN/45mjs6PNo+ekAaQbpDWkT+RqJIRknqS45NNk7aUIJSKlPSVX5XJljSWn5cKl3WX4JhMmLiZJJmQmfyaaJrVm0Kbr5wcnImc951kndKeQJ6unx2fi5/6oGmg2KFHobaiJqKWowajdqPmpFakx6U4pammGqaLpv2nbqfgqFKoxKk3qamqHKqPqwKrdavprFys0K1ErbiuLa6hrxavi7AAsHWw6rFgsdayS7LCszizrrQltJy1E7WKtgG2ebbwt2i34LhZuNG5SrnCuju6tbsuu6e8IbybvRW9j74KvoS+/796v/XAcMDswWfB48JfwtvDWMPUxFHEzsVLxcjGRsbDx0HHv8g9yLzJOsm5yjjKt8s2y7bMNcy1zTXNtc42zrbPN8+40DnQutE80b7SP9LB00TTxtRJ1MvVTtXR1lXW2Ndc1+DYZNjo2WzZ8dp22vvbgNwF3IrdEN2W3hzeot8p36/gNuC94UThzOJT4tvjY+Pr5HPk/OWE5g3mlucf56noMui86Ubp0Opb6uXrcOv77IbtEe2c7ijutO9A78zwWPDl8XLx//KM8xnzp/Q09ML1UPXe9m32+/eK+Bn4qPk4+cf6V/rn+3f8B/yY/Sn9uv5L/tz/bf//
GPUProcessPid: 13972
ClearType Parameters: Gamma: 1.8 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
available by user: Qualified in release
Crash Guard Disabled Features
wmfvpxvideoCrashGuard: Reset on Next Restart

Failure Log
(#0) Error: WMF VPX video decoding is disabled due to a previous crash.
(#1): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#2) Error: WMF VPX video decoding is disabled due to a previous crash.
(#3): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#4) Error: WMF VPX video decoding is disabled due to a previous crash.
(#5): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#6) Error: WMF VPX video decoding is disabled due to a previous crash.
(#7): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#8) Error: WMF VPX video decoding is disabled due to a previous crash.
(#9): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#10) Error: WMF VPX video decoding is disabled due to a previous crash.
(#11): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.
(#12) Error: WMF VPX video decoding is disabled due to a previous crash.
(#13): CP+[GFX1-]: WMF VPX video decoding is disabled due to a previous crash.

Media

Audio Backend: wasapi
Max Channels: 2
Preferred Sample Rate: 48000
Output Devices
Name: Group
Digital Audio (HDMI) (High Definition Audio Device):
Internal AUX Jack (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
Speakers (USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&882660d&0&0000
Digital Audio (HDMI) (High Definition Audio Device):
Speakers (4- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&31637f6f&0&0000
:
BenQ LCD (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
BenQ LCD (High Definition Audio Device):
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
:
Speakers (5- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&2df5c757&0&0000
Headphones (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
LCDTV16 (NVIDIA High Definition Audio):
:
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
:
:
:
Speakers (2- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&2a0dbc6a&0&0000
BenQ LCD (High Definition Audio Device):
:
BenQ LCD (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
Headset (AM61 Hands-Free): BTHHFENUM\BthHFPAudio\9&5ae4bea&3&97
Speakers (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
Speakers (3- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&1b3c16b2&0&0000
:
NVIDIA Output (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
BenQ LCD (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
:
Headphones (AM61 Stereo): BTHENUM{0000110b-0000-1000-8000-00805f9b34fb}_VID&00010039_PID&1582\8&16252d20&0&E09DFA228741_C00000000
Digital Audio (HDMI) (High Definition Audio Device):
Input Devices
Name: Group
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
Microphone (2- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&2a0dbc6a&0&0000
:
:
Internal AUX Jack (High Definition Audio Device):
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
Microphone (4- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&31637f6f&0&0000
:
:
Microphone (USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&882660d&0&0000
Internal AUX Jack (High Definition Audio Device):
Microphone (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
:
Microphone (5- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&2df5c757&0&0000
Internal AUX Jack (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
Microphone (3- USB PnP Sound Device): USB\VID_0D8C&PID_013C&MI_00\7&1b3c16b2&0&0000
Internal AUX Jack (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_0083&SUBSYS_14583792&REV_1001\5&385c8670&0&0001
Headset (AM61 Hands-Free): BTHHFENUM\BthHFPAudio\9&5ae4bea&3&97
Line In (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001
:
Internal AUX Jack (High Definition Audio Device):
Microphone (High Definition Audio Device): HDAUDIO\FUNC_01&VEN_10EC&DEV_0892&SUBSYS_1462F758&REV_1003\4&6098c0c&0&0001

Important Modified Preferences

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.amount_written: 874362
browser.cache.disk.capacity: 1048576
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.hashstats_reported: 1
browser.cache.disk.telemetry_report_ID: 218
browser.sessionstore.upgradeBackup.latestBuildID: 20191030021342
browser.startup.homepage_override.buildID: 20191030021342
browser.startup.homepage_override.mstone: 70.0.1
browser.tabs.tabMinWidth: 100
browser.urlbar.matchBuckets: general:5,suggestion:Infinity
browser.urlbar.placeholderName: DuckDuckGo
browser.urlbar.timesBeforeHidingSuggestionsHint: 0
dom.push.userAgentID: f72688eb42f442a49da18865b3132b10
extensions.lastAppVersion: 70.0.1
font.internaluseonly.changed: false
gfx.crash-guard.status.wmfvpxvideo: 3
gfx.crash-guard.wmfvpxvideo.appVersion: 70.0.1
gfx.crash-guard.wmfvpxvideo.deviceID: 0x1b82
gfx.crash-guard.wmfvpxvideo.driverVersion: 26.21.14.4108
idle.lastDailyNotification: 1575318194
layers.mlgpu.sanity-test-failed: false
media.benchmark.vp9.fps: 185
media.benchmark.vp9.versioncheck: 5
media.gmp-gmpopenh264.abi: x86_64-msvc-x64
media.gmp-gmpopenh264.lastUpdate: 1571817241
media.gmp-gmpopenh264.version: 1.8.1.1
media.gmp-manager.buildID: 20191030021342
media.gmp-manager.lastCheck: 1575201951
media.gmp-widevinecdm.abi: x86_64-msvc-x64
media.gmp-widevinecdm.lastUpdate: 1567668799
media.gmp-widevinecdm.version: 4.10.1440.19
media.gmp.storage.version.observed: 1
media.hardware-video-decoding.failed: false
media.videocontrols.picture-in-picture.enabled: true
media.videocontrols.picture-in-picture.video-toggle.enabled: true
media.videocontrols.picture-in-picture.video-toggle.flyout-enabled: true
network.dns.disablePrefetch: true
network.http.speculative-parallel-limit: 0
network.predictor.enabled: false
network.prefetch-next: false
network.trr.custom_uri: https://doh-fi.blahdns.com/dns-query
network.trr.mode: 2
places.database.lastMaintenance: 1575225335
places.history.expiration.transient_current_max_pages: 102534
plugin.disable_full_page_plugin_for_types: application/pdf
privacy.cpd.cache: false
privacy.cpd.cookies: false
privacy.cpd.sessions: false
privacy.donottrackheader.enabled: true
privacy.sanitize.pending: [{"id":"newtab-container","itemsToClear":[],"options":{}}]
privacy.socialtracking.notification.counter: 2
privacy.socialtracking.notification.enabled: false
privacy.socialtracking.notification.lastShown: 1572080606869
privacy.trackingprotection.enabled: true
privacy.trackingprotection.socialtracking.enabled: true
security.remote_settings.intermediates.checked: 1562700449
security.sandbox.content.tempDirSuffix: {a6b133cf-4dc7-4155-aad6-583ac5c679a4}
security.sandbox.plugin.tempDirSuffix: {f5c9a272-e987-4695-8418-c2ec8d347a09}
services.sync.declinedEngines:
services.sync.engine.prefs.modified: false
services.sync.lastPing: 1575313839
services.sync.lastSync: Tue Dec 03 2019 02:33:49 GMT+0300 (Moscow Standard Time)
signon.importedFromSqlite: true
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1574102293
ui.osk.debug.keyboardDisplayReason: IKPOS: Touch screen not found.

Important Locked Preferences

Places Database

JavaScript

Incremental GC: true

Accessibility

Activated: false
Prevent Accessibility: 0
Accessible Handler Used: true
Accessibility Instantiator:

Library Versions

NSPR
Expected minimum version: 4.22
Version in use: 4.22

NSS
Expected minimum version: 3.46.1
Version in use: 3.46.1

NSSSMIME
Expected minimum version: 3.46.1
Version in use: 3.46.1

NSSSSL
Expected minimum version: 3.46.1
Version in use: 3.46.1

NSSUTIL
Expected minimum version: 3.46.1
Version in use: 3.46.1

Sandbox

Content Process Sandbox Level: 5
Effective Content Process Sandbox Level: 5

Internationalization & Localization

Application Settings
Requested Locales: ["en-US"]
Available Locales: ["en-US"]
App Locales: ["en-US"]
Regional Preferences: ["en-US"]
Default Locale: "en-US"
Operating System
System Locales: ["en-US"]
Regional Preferences: ["en-US"]

Comment 18

[Sergey Ivanov]

also i use 4k monitor and see 1080 60 fps video

Comment 19

[Aria Beingessner [:Gankra]]

So a bit more notes after a bit of Research and Theory Crafting™

• PiP creates a new WR window that is driven independently of the original
• mconley mentioned that the way PiP is setup, we "send" the video frames to both windows (in a way that only does one upload/decode).
• mconley also mentioned while print debugging HoldExternalImage that there were clearly 2 mTextureHostsUntilRenderCompleted instances, one growing forever, and one staying at ~3 textures
• With PiP enabled, if you pull up the WR debugger, the seemingly-static main window is still getting slammed with composition requests (at the video's FPS), as if it were actually painting the video (this is probably inherently bad for battery and should be fixed anyway).

So it seems to me that the issue is that we're pointlessly(?) sending our video frames to the main window and asking it to composite them. The two mTextureHostsUntilRenderCompleted are probably the main window and the PiP, with the growing one being the main window. When we minimize the main window it presumably stops responding to composition requests, causing all of the "useless" video frames being sent to it to pile up forever.

Since all the composition requests for the main window are wasteful anyway, it seems to me that the fix should be targetted at not sending video frames to the main window when PiP is enabled.

Sotaro, does this make sense to you? Is there some special reason we need to send the main window all of our video frames?

Comment 20

[MrX1980]

Could it be that the problem does not occur, if the Firefox window is not maximized before we minimize it?
Because if I snap the Firefox window to the left or right, so it resize to the half size of the display, and then use PiP and minimize the Firefox window, I see at Task Manager -> Performance -> GPU that GPU memory looks like "stairs" (up and down).
If I do the same test, but this time maximize the Firefox window, use PiP and minimize the Firefox window, I see the "incease" until it crashes or the video stops.

Comment 21

[Sotaro Ikeda [:sotaro]]

In the past there were similar bug with compositor(non-WebRender). Bug 1287627.

Comment 22

[Sotaro Ikeda [:sotaro]]

It seems like a regression of Bug 1589718 . The memory leak happens because wr::WebRenderPipelineInfo is not handled by AsyncImagePipelineManager::NotifyPipelinesUpdated(). Since Bug 1589718 fix, the info is handled only when webrender does rendering in RenderThread::UpdateAndRender(). But the info is valid even when WR does not do rendering.

video frames to the main window

It seems not directly related to this bug. But there are several points to do it. One simple fix is using mWidget->IsHidden() like CompositorD3D11::BeginFrame().

• https://searchfox.org/mozilla-central/rev/8bc24752246aeac8a9aed566cf1caccf88d97d11/gfx/layers/d3d11/CompositorD3D11.cpp#1145

Comment 23

[Jim Mathies [:jimm]]

updating tracking, let us know if this looks right.

Comment 24

[Bob Owen (:bobowen)]

(In reply to Sotaro Ikeda [:sotaro] from comment #22)

It seems like a regression of Bug 1589718 .

Are you sure about that?
I don't see the crash, but I do see the same memory issues and I can reproduce in Fx71 (Bug 1589718 landed in Fx72).
The original report is against 71 as well.

The memory leak happens because wr::WebRenderPipelineInfo is not handled by AsyncImagePipelineManager::NotifyPipelinesUpdated(). Since Bug 1589718 fix, the info is handled only when webrender does rendering in RenderThread::UpdateAndRender(). But the info is valid even when WR does not do rendering.

As I understand it, that is how it worked before.
NotifyPipelinesUpdated was passed a bool param (aRender) and ProcessPipelineUpdates was only submitted to the compositor thread if it was true.

Comment 25

[Sotaro Ikeda [:sotaro]]

(In reply to Bob Owen (:bobowen) from comment #24)

(In reply to Sotaro Ikeda [:sotaro] from comment #22)

As I understand it, that is how it worked before.
NotifyPipelinesUpdated was passed a bool param (aRender) and ProcessPipelineUpdates was only submitted to the compositor thread if it was true.

Sorry, I did not check the previous code. Previous code also had the problem.

Comment 26

[Sotaro Ikeda [:sotaro]]

:Gankra, I want to take this bug, since I caused the regression. Is it OK for you? Thanks.

Comment 27

[Aria Beingessner [:Gankra]]

Sure thing! Was just trying to take a few things off your plate.

Comment 28

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1599887 - Update frame is when WR rendering is skipped

Comment 29

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c815878c7e7e68987b4ff01b0c33c9e25445a35a

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3590d2512df
Update frame is when WR rendering is skipped r=nical

Comment 31

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f3590d2512df

Comment 32

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request?

Comment 33

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9113668 [details]
Bug 1599887 - Update frame is when WR rendering is skipped

Beta/Release Uplift Approval Request

• User impact if declined: OOM crah could happen in the STR.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix is simple. With the patch, FrameId is updated even when WR skip rendering.
• String changes made/needed: none

Comment 34

[Julien Cristau [:jcristau]]

Comment on attachment 9113668 [details]
Bug 1599887 - Update frame is when WR rendering is skipped

wr fix for 72.0b6

Comment 35

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f47c7a65a298

Comment 36

[Andreea Pavel [:apavel]]

Backed out for win build bustages at RenderCompositorANGLE.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&selectedJob=280892717&resultStatus=testfailed%2Cbusted%2Cexception&revision=e126c811e8e34ab27a258d304c5996201f974575

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280892717&repo=mozilla-beta&lineNumber=24288

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/9f314235e38f7b58773a9316d66d4b05676fbeb8

Comment 37

[Ryan VanderMeulen [:RyanVM]]

Just needs a minor rebase around bug 1600533 - I'm running it through Try now.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

Green on Try.

https://hg.mozilla.org/releases/mozilla-beta/rev/df7307e2d59a

Comment 40

[Rares Doghi, Desktop QA]

Hi, I tried to reproduce this issue on a desktop pc with 16 Gb of ram and a 4k monitor, In Firefox release 71 on both websites the CPU and Memory would go up to 80% but It never crashed, In our latest beta build 72.0b7 and our latest Nightly build the CPU and Memory did not go above 50%, it was mostly around 34%, based on these results I think we can mark them with Verified as Fixed but I wouldnt change the flags without a second opinion, :sotaro can you please take a look at these results and let us know if we can update the flags ?

Comment 41

[Sotaro Ikeda [:sotaro]]

Yea, we could update the flags. I also confirmed that the memory usage problem existed on 71 and it was addressed on beta and nightly.

Comment 42

[Rares Doghi, Desktop QA]

Based on Comment 40 and 41, This issue is verified as fixed, I will update the flags.