1600000 - Simplify functions to select a search engine list in search's xpcshell head.js

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Currently we have three functions in head.js that are doing very similar things:

https://searchfox.org/mozilla-central/rev/4df8821c1b824db5f40f381f48432f219d99ae36/toolkit/components/search/tests/xpcshell/head_search.js#75,92,204

• configureToLoadJarEngines
• useTestEngines
• useTestEngineConfig

The first two are actually near-duplicates, configureToLoadJarEngines just has a hard-coded value rather that it being passed in.

In bug 1542269, I need to change how the engine loading works for the modern configuration, therefore I'd like to merge these all into one async function to make that work easier.

I'm doing the change to async here, as I know it'll need to be async, and it saves extra blame.

Comment 1

[Mark Banner (:standard8)]

Note, I'm also tagging on removing an unused function from our browser mochitest's head.js.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1600000 - Remove unused promiseTabLoadEvent from search's mochitest head.js. r?mikedeboer

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1600000 - Simplify functions to select a search engine list in search's xpcshell head.js. r?mikedeboer

Depends on D55077

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be31ae31be0
Remove unused promiseTabLoadEvent from search's mochitest head.js. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/8d42aaa5b911
Simplify functions to select a search engine list in search's xpcshell head.js. r=mikedeboer

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2be31ae31be0
https://hg.mozilla.org/mozilla-central/rev/8d42aaa5b911