1542269 - Migrate the new Search Engine configuration to be loaded from RemoteSettings

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Once we've introduced the new configuration and integrated it (bug 1542268), we should allow it to be updated remotely so that we can replace the existing AB mechanism, and allow engine updates to happen more easily.

Comment 1

[Bridget Kaluzny]

May have to land in 71- not nec preffable

Comment 2

[Mark Banner (:standard8)]

In this bug we should also work out what happens if the configuration can't be found/loaded. Currently we fail initialisation, and as a result, we might stop parts of the browser working, e.g. address bar. It might be better to treat things the same as the legacy configuration - run with an empty set of engines, and don't fail initialisation. This should mean that at least some features can still work in the absolute worst case.

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9071f6f92bf2d9156f57b98640990be422efa092

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1542269 - In search tests, when running asyncReInit, don't reset the search service. r?mikedeboer

SearchService.reset() isn't designed to be called with reInit, but with init.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1542269 - Switch some more search xpcshell-tests to use the useTestEngines helper function. r?mikedeboer

Depends on D55462

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r?daleharvey

Depends on D55463

Comment 7

[Phabricator Automation]

Comment on attachment 9112900 [details]
Bug 1542269 - In search tests, when running asyncReInit, don't reset the search service. r?mikedeboer

Revision D55462 was moved to bug 1601633. Setting attachment 9112900 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9112901 [details]
Bug 1542269 - Switch some more search xpcshell-tests to use the useTestEngines helper function. r?mikedeboer

Revision D55463 was moved to bug 1601633. Setting attachment 9112901 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb19bd67310f
Make the modern search engine configuration be loaded from Remote Settings. r=daleharvey

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bb19bd67310f