160008 - Location entry sheet dialog should support autocomplete and bookmark keywords

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Simon Fraser [no longer active]]

When you have the toolbar in text mode, doing Command-L shows a sheet dialog to
enter the url. This dialog needs to support autocomplete just like the URL bar does.

Comment 1

[saari (gone)]

->pinkerton

Comment 2

[Greg K.]

Confirmed using Chimera/20020724.

Comment 3

[David Haas (gone, not reading mail)]

FYI: Changing the location sheet NSTextField to a CHAutoCompleteTextField in the
nib fixes this, but the location of the autocomplete window is, um, "unoptimal".

Comment 4

[Mike Pinkerton (not reading bugmail)]

i played with this a little when it was a NSTextView. There were some issues
with the enter/escape keys because they mean different things to teh
autocomplete than they mean in a dialog. Not sure how to resolve that.

we should probably fix up the text field's code that positions the popup to do a
better search for its parent than assuming it's at a certain depth.

Comment 5

[David Haas (gone, not reading mail)]

I'm gonna claim this bug (at least for a bit) if nobody has a problem with that.
 I want to try something mildly ambitious and don't want it fixed before I'm done.

Comment 6

[David Haas (gone, not reading mail)]

Attachment: lots of stuff

this patch smartens up the AutoCompleteTextField class so that when it's used
in the location sheet, you get autocomplete functions.

also, when appearing in the toolbar, it correctly indicates that it has focus
(which is what I really wanted to do and took forever to figure out).

in the course of this, i moved the proxy icon setting stuff from the
browserwindowcontroller to autocompletetextfield.

the way it works now, autocompletetextfields have to be made programmatically -
they can't be made in IB.  if this really bothers anyone, i'll make a palette.
i think that should fix things.

there may have been some other random changes. i don't remember.

Comment 7

[David Haas (gone, not reading mail)]

Attachment: browserwindow.nib.tgz

here's the zipped up browserwindow.nib.  it's somewhat important for the patch.


i hope this was everything needed . . .

Comment 8

[David Haas (gone, not reading mail)]

Comment on attachment 96540 [details] [diff] [review]
lots of stuff

urk.  need to fix something here.  3 am patch submissions bad.

Comment 9

[saari (gone)]

what's the status on this? Seems like a good thing to fix

Comment 10

[Jasper]

Yes why doesn't any dev seem to pickup this rather usefull patch? There are
several post her on bugzilla that contains patches on which the devs haven't
reacted yet for a while now?

Comment 11

[Simon Fraser [no longer active]]

*** Bug 184273 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Pinkerton (not reading bugmail)]

oh, the reason was because it dropped off everyone's radar since dave kept it
assigned to himself! :)

dave, is the nib up to date? we'd love to get this feature in.

Comment 13

[Mike Pinkerton (not reading bugmail)]

*** Bug 175460 has been marked as a duplicate of this bug. ***

Comment 14

[Jasper]

Dave could you please update?

Comment 15

[Jasper]

Attachment: updated browser window nib

Updated nib file. Just copied the locationSheet from davids nib file and pasted
in the newer browserwindo.nib

Comment 16

[Mike Pinkerton (not reading bugmail)]

*** Bug 213736 has been marked as a duplicate of this bug. ***

Comment 17

[Stuart Morgan]

*** Bug 244999 has been marked as a duplicate of this bug. ***

Comment 18

[Stuart Morgan]

*** Bug 246440 has been marked as a duplicate of this bug. ***

Comment 19

[Jasper]

Mike can you put this back on your radar, it has been sitting here all done but
not landed yet. 

Comment 20

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 96542 [details]
browserwindow.nib.tgz

asking geoff for review

Comment 21

[Josh Aas]

would like to have it, but it shouldn't block 0.9 at this point

Comment 22

[Samuel Sidler (old account; do not CC)]

Mike, Josh, can you put this back on your radar and check out/in the patch?

Comment 23

[Ben Medina]

*** Bug 302055 has been marked as a duplicate of this bug. ***

Comment 24

[Samuel Sidler (old account; do not CC)]

Mike, since you removed the review request for Geoff, care to do it yourself? ;)
If everything is here and still valid, we should be able to land this.

Comment 25

[Simon Fraser [no longer active]]

Taking.

Comment 26

[Simon Fraser [no longer active]]

Fixed.

Comment 27

[Ulrik Sverdrup]

Attachment: Patch to resolve bookmark keywords in the sheet

This bug should be reopened; the keyword part was never fixed. 
This patch fixes bookmark keyword resolution from the location sheet.

Comment 28

[Ulrik Sverdrup]

Attachment: Patch to make the location sheet resolve keywords v2

The previous patch was stupid, here is a better one (one line changed)

Comment 29

[Simon Fraser [no longer active]]

Comment on attachment 194992 [details] [diff] [review]
Patch to make the location sheet resolve keywords v2

That makes more sense!

Comment 30

[Ulrik Sverdrup]

Comment on attachment 194992 [details] [diff] [review]
Patch to make the location sheet resolve keywords v2

Requesting superreview

Comment 31

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 194992 [details] [diff] [review]
Patch to make the location sheet resolve keywords v2

sr=pink

Comment 32

[Simon Fraser [no longer active]]

Fixed on branch and trunk.