1600874 - Fix Site Identity mochitests for Fission enabled

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P2)

Description

[Chris Peterson [:cpeterson]]

Some Site Identity mochitests fail when Fission is enabled:

Test Name	Opt Test	Debug Test
browser/base/content/test/popups/browser_popup_frames.js	fails	fails
browser/base/content/test/siteIdentity/browser_bug1045809.js	fails	fails
browser/base/content/test/siteIdentity/browser_identityPopup_clearSiteData.js	passes	skipped (why?)
browser/base/content/test/siteIdentity/browser_mixedContentFramesOnHttp.js	fails	fails

These Site Identity test failures can't be fixed until MixedContentBlocker supports Fission (bug 1584157).

Tracking for Fission milestone M4.1 because we want to fix all mochitests in the current Fission milestone.

Tentatively assigning this bug to Ninanth because he is the Site Identity component owner.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I've filed bug 1611484 to enable browser_popup_frames.js, which I think we can do now without the MixedContentBlocker stuff.

Comment 2

[Chris Peterson [:cpeterson]]

Nihanth, there are still three Site Identity tests failing or skipped for Fission. Can you help find a front-end engineer to fix and re-enable these tests?

https://searchfox.org/mozilla-central/search?q=fission&path=browser%2Fbase%2Fcontent%2Ftest%2FsiteIdentity%2F&case=true&regexp=false

browser_bug1045809.js
browser_identityPopup_clearSiteData.js
browser_mixedContentFramesOnHttp.js

Comment 3

[Chris Peterson [:cpeterson]]

The Fission team hopes to roll out Fission to some Nightly users in Q3, so it would be good if all tests are passing and enabled for Fission by the end of Q2.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b32d7d81cfffd8cb322a4c12f32c2bdca714ac73

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #4)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b32d7d81cfffd8cb322a4c12f32c2bdca714ac73

Looks like there are still lots of M-fis test timeouts.

Comment 6

[Chris Peterson [:cpeterson]]

Nihanth, what are the next steps for fixing this Fission bug?

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1600874 - Enable browser_identityPopup_clearSiteData.js on fission. r=pbz!

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=800a365347098f51035f93d8bdd7ab72ebdf2213

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b07236568046
Enable browser_identityPopup_clearSiteData.js on fission. r=pbz

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b07236568046