1600916 - maven.mozilla.org: Make beetmover fail whenever an invalid MavenVersion is passed

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Uploading, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

In order to prevent bug 1600914 from happening again, we need beetmover to error out whenever MavenVersion cannot parse the version. In fact, maven-lambda uses this parser to process the functions. Therefore, it's a matter of using it in beetmover too. We may need to parse the path defined in declarative artifacts.

[1] https://github.com/mozilla-releng/maven-lambda/blob/cca6eb9c67af6300b821c26a072ff0e3aedd174d/maven_lambda/metadata.py#L265

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [beetmoverscript] part I - cleanup of the maven/zip world

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging, not actively working on this bug, returning to the pool.
Happy to mentor someone to finish. It's a matter of re-doing the logic from https://github.com/mozilla-releng/scriptworker-scripts/blob/e57086624a11d3d58878f18e7664dd6416c0091c/beetmoverscript/src/beetmoverscript/utils.py#L190 in a slightly different place in beetmoverscript (parsing paths from the payload somewhere around or so https://github.com/mozilla-releng/scriptworker-scripts/blob/e57086624a11d3d58878f18e7664dd6416c0091c/beetmoverscript/src/beetmoverscript/task.py#L112 that is used called

Comment 3

[alex.lopez.zorzano]

I can try to help with this but I'll probably need some help getting started since I'm not familiar with the code. I'll read around and see if I can figure things out.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Hi Alex!

Thank you very much for your interest! Mihai is on vacation this week, but I can help you out in the meantime. Comment 2 contains the main pointers, but I understand if you'd need more context. I'm happy to provide answers either here on this bug or on chat.mozilla.org. On the latter, you can find me under the nickname jlorenzo.

Looking forward to hearing from you soon!

Comment 5

[alex.lopez.zorzano]

Under Johan's guidance I've made a first attempt at solving this. I don't know how to attach pull requests here, so I'll simply post the link for reference: https://github.com/mozilla-releng/scriptworker-scripts/pull/277.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Thanks a lot for working on this Alex!
Adjusting the bug fields to reflect reality. Thanks Johan for picking this up from our side!

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to alex.lopez.zorzano from comment #5)

Under Johan's guidance I've made a first attempt at solving this. I don't know how to attach pull requests here, so I'll simply post the link for reference: https://github.com/mozilla-releng/scriptworker-scripts/pull/277.

Dropping this in the comments works as well, no worries! If you wanted to attach to the bug, one should

• attach new file
• put the PR URL https://github.com/mozilla-releng/scriptworker-scripts/pull/277 under the File section
• tick enter manually and set it to text/x-github-pull-request (should be auto-populated at this point with this)

But again, this is not a requirement, a comment suffices too.

Comment 8

[alex.lopez.zorzano]

Attachment: [beetmoverscript] Check maven artifact version

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Thanks for adding that! I missed to mention to add the description as well, usually as the PR title. I did that just now.

Comment 10

[alex.lopez.zorzano]

Attachment: [android-components] Add version field to task payload for beetmover

Comment 11

[alex.lopez.zorzano]

Attachment: Bug 1600916 - Change version field on geckoview beetmover to valid Maven version. r=jlorenzo

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0abf4e0c4d22
Change version field on geckoview beetmover to valid Maven version. r=jlorenzo

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/03de9a8a6f7c
Change version field on geckoview beetmover to valid Maven version. r=jlorenzo a=bustage-fix

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/03de9a8a6f7c

Comment 15

[Johan Lorenzo [:jlorenzo]]

Amazing job, Alex! This bug turned out to be much harder than a simple "good first bug" and you nailed it! I see today's geckoview nightly is green[1]. I'm glad we now have this check, thanks to you! It bit us in the past, and we now have a way to explicitly error out on it. Thank you!

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=beetmover-geckoview&revision=03de9a8a6f7c949b046b5a1197988391ede9e84f

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0abf4e0c4d22