Closed Bug 1601247 Opened 6 years ago Closed 6 years ago

Perma TEST-UNEXPECTED-TIMEOUT | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | Test timed out when Gecko 73 merges to Beta on 06-01-20

Tracking

()

Status:

VERIFIED FIXED

Milestone:

Firefox 73

Tracking Flags:

Tracking

Status

firefox-esr68

---

unaffected

firefox71

---

unaffected

firefox72

---

fixed

firefox73

verified

People

(Reporter: dvarga, Assigned: nhnt11)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1601247 - Call AddonTestUtils.overrideCertDB() in doh-rollout test to ensure it's considered privileged. r=zombie! 6 years ago (inactive) Nihanth Subramanya [:nhnt11] 47 bytes, text/x-phabricator-request	lizzard : approval-mozilla-beta+	Details \| Review

Multiple Authors

Description

•

6 years ago

•

Edited

Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=279538158&revision=e5ba0286cc5e5b479a831b5e9f04244d3fbd52e9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279538158&repo=try&lineNumber=2601

[task 2019-12-04T11:00:45.868Z] 11:00:45     INFO -  TEST-START | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js
[task 2019-12-04T11:05:45.881Z] 11:05:45  WARNING -  TEST-UNEXPECTED-TIMEOUT | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | Test timed out
[task 2019-12-04T11:05:45.882Z] 11:05:45     INFO -  TEST-INFO took 300000ms
[task 2019-12-04T11:05:45.883Z] 11:05:45     INFO -  >>>>>>>

...

[task 2019-12-04T11:05:46.011Z] 11:05:46     INFO -  "CONSOLE_MESSAGE: (info) 1575457248572	addons.webextension.doh-rollout@mozilla.org	WARN	Loading extension 'doh-rollout@mozilla.org': Reading manifest: Invalid extension permission: networkStatus"
[task 2019-12-04T11:05:46.011Z] 11:05:46     INFO -  PID 15246 | [Parent 15246, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-12-04T11:05:46.012Z] 11:05:46     INFO -  PID 15246 | [15315, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-12-04T11:05:46.012Z] 11:05:46     INFO -  PID 15246 | [15315, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-12-04T11:05:46.012Z] 11:05:46     INFO -  PID 15246 | nsStringStats
[task 2019-12-04T11:05:46.013Z] 11:05:46     INFO -  PID 15246 |  => mAllocCount:           6835
[task 2019-12-04T11:05:46.013Z] 11:05:46     INFO -  PID 15246 |  => mReallocCount:            0
[task 2019-12-04T11:05:46.013Z] 11:05:46     INFO -  PID 15246 |  => mFreeCount:            6835
[task 2019-12-04T11:05:46.014Z] 11:05:46     INFO -  PID 15246 |  => mShareCount:           3355
[task 2019-12-04T11:05:46.014Z] 11:05:46     INFO -  PID 15246 |  => mAdoptCount:            266
[task 2019-12-04T11:05:46.014Z] 11:05:46     INFO -  PID 15246 |  => mAdoptFreeCount:        272
[task 2019-12-04T11:05:46.015Z] 11:05:46     INFO -  PID 15246 |  => Process ID: 15282, Thread ID: 139667499741184
[task 2019-12-04T11:05:46.015Z] 11:05:46     INFO -  PID 15246 | [Child 15315, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-12-04T11:05:46.015Z] 11:05:46     INFO -  PID 15246 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-12-04T11:05:46.015Z] 11:05:46     INFO -  PID 15246 | [Child 15315, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2019-12-04T11:05:46.016Z] 11:05:46     INFO -  PID 15246 | [Child 15315, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2755
[task 2019-12-04T11:05:46.016Z] 11:05:46     INFO -  PID 15246 | [Child 15315, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80070057: file /builds/worker/workspace/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 671
[task 2019-12-04T11:05:46.016Z] 11:05:46     INFO -  PID 15246 | JavaScript error: moz-extension://ba05d17d-ac7e-4088-864d-a38cc85bcbf3/background.js, line 525: TypeError: browser.experiments.preferences is undefined
[task 2019-12-04T11:05:46.017Z] 11:05:46     INFO -  PID 15246 | 1575457249023	addons.xpi	DEBUG	Install of temporary addon in /builds/worker/workspace/build/application/firefox/browser/features/doh-rollout@mozilla.org.xpi completed.
[task 2019-12-04T11:05:46.017Z] 11:05:46     INFO -  "CONSOLE_MESSAGE: (info) 1575457249023	addons.xpi	DEBUG	Install of temporary addon in /builds/worker/workspace/build/application/firefox/browser/features/doh-rollout@mozilla.org.xpi completed."
[task 2019-12-04T11:05:46.017Z] 11:05:46     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "TypeError: browser.experiments.preferences is undefined" {file: "moz-extension://ba05d17d-ac7e-4088-864d-a38cc85bcbf3/background.js" line: 525}]"
[task 2019-12-04T11:05:46.017Z] 11:05:46     INFO -  PID 15246 | [15343, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-12-04T11:05:46.018Z] 11:05:46     INFO -  PID 15246 | [15343, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-12-04T11:05:46.018Z] 11:05:46     INFO -  PID 15246 | [Child 15343, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-12-04T11:05:46.018Z] 11:05:46     INFO -  PID 15246 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-12-04T11:05:46.018Z] 11:05:46     INFO -  PID 15246 | [Child 15343, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 381
[task 2019-12-04T11:05:46.018Z] 11:05:46     INFO -  <<<<<<<

Daniel Varga [:dvarga]

Reporter

Comment 1

•

6 years ago

:nhnt11, Can you please take a look?

Flags: needinfo?(nhnt11)

Cristina Coroiu [:ccoroiu]

Comment 2

•

6 years ago

[Tracking Requested - why for this release]:

status-firefox73: ? → affected

tracking-firefox73: --- → ?

(inactive) Nihanth Subramanya [:nhnt11]

Assignee

Comment 3

•

6 years ago

Seems like this is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1599756#c2, fix coming up.

Flags: needinfo?(nhnt11)

(inactive) Nihanth Subramanya [:nhnt11]

Assignee

Comment 4

•

6 years ago

Attached file Bug 1601247 - Call AddonTestUtils.overrideCertDB() in doh-rollout test to ensure it's considered privileged. r=zombie! — Details

Phabricator Automation

Updated

•

6 years ago

Assignee: nobody → nhnt11

(inactive) Nihanth Subramanya [:nhnt11]

Assignee

Comment 5

•

6 years ago

beta-sim on try with the patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f04591ead48dc69949347a1d23e7cad56b04ae5

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 6

•

6 years ago

beta sim with less tasks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=369615f470f9d30ca506a6fbf4b1bbdf7e759400

Pulsebot

Comment 7

•

6 years ago

Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d31fb2178114 Call AddonTestUtils.overrideCertDB() in doh-rollout test to ensure it's considered privileged. r=zombie

Andreea Pavel [:apavel]

Comment 8

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d31fb2178114

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox73: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 73

Andreea Pavel [:apavel]

Comment 9

•

6 years ago

No longer occurs on recent beta sims:

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=f124f840312c470608ea7480fe699d994c0d3883&searchStr=x1&selectedJob=279989739

Status: RESOLVED → VERIFIED

status-firefox73: fixed → verified

Ryan VanderMeulen [:RyanVM]

Updated

•

6 years ago

tracking-firefox73: ? → +

(inactive) Nihanth Subramanya [:nhnt11]

Assignee

Comment 10

•

6 years ago

Comment on attachment 9113438 [details]
Bug 1601247 - Call AddonTestUtils.overrideCertDB() in doh-rollout test to ensure it's considered privileged. r=zombie!

Beta/Release Uplift Approval Request

User impact if declined: No direct impact. This patch supports bug 1600783, which lands tests that were previously missing. Uplifting to beta just ensures that the tests run on beta as well, as good practice.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: Bug 1600783
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): From bug 1600783 comment 7:

Similar to bug 1598221 - in my opinion, the change is not risky because it just adds tests and removes a line of code to fix a rare bug. The only (very unlikely) cause of failure I can see is something I missed that leads to the tests failing on beta. And in that case we'd detect it pretty quick.

String changes made/needed:

Attachment #9113438 - Flags: approval-mozilla-beta?

BugBot [:suhaib / :marco/ :calixte]

Updated

•

6 years ago

Keywords: regression

Liz Henry (:lizzard) (relman/hg->git project)

Comment 11

•

6 years ago

Comment on attachment 9113438 [details]
Bug 1601247 - Call AddonTestUtils.overrideCertDB() in doh-rollout test to ensure it's considered privileged. r=zombie!

Test fix to support DoH. OK for uplift for the RC build.

Attachment #9113438 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Noemi Erli[:noemi_erli]

Comment 12

•

6 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/44067be8bf24

Liz Henry (:lizzard) (relman/hg->git project)

Updated

•

6 years ago

status-firefox72: unaffected → fixed

BugBot [:suhaib / :marco/ :calixte]

Updated

•

4 years ago

Has Regression Range: --- → yes

You need to log in before you can comment on or make changes to this bug.