1600783 - Test doh-rollout addon's local storage migration

Status: RESOLVED FIXED

(Firefox :: Security, task, P1)

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1600783 - Test doh-rollout addon's local storage migration. r=mixedpuppy!,maxxcrawford!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5a8226554d8
Test doh-rollout addon's local storage migration. r=mixedpuppy,maxxcrawford

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset a5a8226554d8 (Bug 1600783) for causing failures in browser_localStorageMigration.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=a5a8226554d86800ca4c94bd2e1b2d256eb8d6fe&selectedJob=279195423

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279196123&repo=autoland&lineNumber=1565

Backout: https://hg.mozilla.org/integration/autoland/rev/4d9adeb56c3217b5082d6420e5e80af92072b737

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

This ran into my old friend bug 1548006. Luckily I am older and wiser now and managed to convert this to an xpcshell test.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2370c28289aeace3200d4e58577e512c5776a4d4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a81886e0c37
Test doh-rollout addon's local storage migration. r=mixedpuppy,maxxcrawford

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5a81886e0c37

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9113045 [details]
Bug 1600783 - Test doh-rollout addon's local storage migration. r=mixedpuppy!,maxxcrawford!

Beta/Release Uplift Approval Request

• User impact if declined: No direct impact. This patch lands tests that were previously missing. Uplifting to beta just ensures that the tests run on beta as well, as good practice.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Similar to bug 1598221 - in my opinion, the change is not risky because it just adds tests and removes a line of code to fix a rare bug. The only (very unlikely) cause of failure I can see is something I missed that leads to the tests failing on beta. And in that case we'd detect it pretty quick.
• String changes made/needed:

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9113045 [details]
Bug 1600783 - Test doh-rollout addon's local storage migration. r=mixedpuppy!,maxxcrawford!

Minor fix + enabling tests on beta. OK for uplift for today's beta 11 build.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b52232c9f82c

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

This just got backed out because I failed to note that the uplift also requires bug 1601247 to be uplifted. Sorry about this. Requesting uplift on that patch in a moment.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

This was backed out yesterday: https://hg.mozilla.org/releases/mozilla-beta/rev/06a6f546bdc80d35479da191678ace26529db40f

It should be OK to re-land it now along with the patch in bug 1601247.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17346534f9c6