1601517 - Intermittent comm/mail/test/browser/cloudfile/browser_notifications.js | Uncaught exception - at resource://testing-common/mozmill/utils.jsm:386 - TimeoutError: Timed out waiting for notification with value bigAttachmentUploading to show.

Status: RESOLVED FIXED

(Thunderbird :: FileLink, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279530636&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eacvaS6tSdm-h9YhDqSYpw/runs/0/artifacts/public/logs/live_backing.log

---

This is the same problem that has been causing the crash in Z1 tests for some time.

Comment 2

[Intermittent Failures Robot]

17 failures in 5144 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 17

Platform breakdown:

• linux64: 4
• windows10-64: 9
• windows10-64-shippable: 1
• linux32: 2
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2019-12-02&endday=2019-12-08&tree=all

Comment 3

[Intermittent Failures Robot]

11 failures in 4867 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 11

Platform breakdown:

• windows10-64-shippable: 2
• linux32: 3
• macosx1014-64: 1
• windows7-32: 1
• linux64: 2
• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2019-12-09&endday=2019-12-15&tree=all

Comment 4

[Intermittent Failures Robot]

8 failures in 4582 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 8

Platform breakdown:

• windows10-64: 6
• macosx1014-64: 1
• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 5

[Intermittent Failures Robot]

12 failures in 1365 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 12

Platform breakdown:

• windows10-64: 8
• macosx1014-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 6

[Intermittent Failures Robot]

15 failures in 1862 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• comm-central: 15

Platform breakdown:

• windows10-64: 11
• linux64: 2
• windows7-32: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1601517_test_fix_browser_notifications.patch

Make sure to wait for the notification to actually appear instead of testing it is already there.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a8d24cceff7115cff0928df0b34bae11297e7b7f&selectedJob=284579438

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9120332 [details] [diff] [review]
bug1601517_test_fix_browser_notifications.patch

Review of attachment 9120332 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like a good idea.

::: mail/test/browser/cloudfile/browser_notifications.js
@@ +30,5 @@
>  var mozmill = ChromeUtils.import(
>    "resource://testing-common/mozmill/mozmill.jsm"
>  );
>  var {
>    assert_notification_displayed,

Do we still need assert_notification_displayed?

Comment 9

[Intermittent Failures Robot]

19 failures in 4472 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 19

Platform breakdown:

• windows10-64-shippable: 4
• windows10-64: 8
• windows7-32: 3
• macosx1014-64: 1
• linux32: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 10

[Magnus Melin [:mkmelin]]

We do, but it's possible the usages should be converted into waiting instead. It's not entirely trivial, so I'll just leave it for now and we can see if it's needed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78ee796295d6
fix comm/mail/test/browser/cloudfile/browser_notifications.js .... Expected the notification with value bigAttachmentUploading to be shown. r=darktrojan

Comment 12

[Magnus Melin [:mkmelin]]

Still seeing it :(

Comment 13

[Intermittent Failures Robot]

26 failures in 3773 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 26

Platform breakdown:

• windows10-64: 13
• windows7-32: 5
• windows10-64-shippable: 2
• linux32: 3
• macosx1014-64: 2
• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-01-13&endday=2020-01-19&tree=all

Comment 14

[Intermittent Failures Robot]

15 failures in 4004 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 15

Platform breakdown:

• macosx1014-64: 2
• windows10-64: 6
• windows7-32: 3
• linux32: 1
• windows10-64-shippable: 1
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-01-20&endday=2020-01-26&tree=all

Comment 15

[Intermittent Failures Robot]

21 failures in 2190 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #31 most frequent failure this week.

Repository breakdown:

• comm-central: 21

Platform breakdown:

• windows10-64: 10
• macosx1014-64: 4
• linux64: 5
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-01-27&endday=2020-02-02&tree=all

Comment 16

[Intermittent Failures Robot]

17 failures in 3364 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 17

Platform breakdown:

• windows10-64: 11
• windows10-64-shippable: 3
• linux64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-02-03&endday=2020-02-09&tree=all

Comment 17

[Intermittent Failures Robot]

15 failures in 4690 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 15

Platform breakdown:

• windows10-64: 5
• macosx1014-64: 2
• windows10-64-shippable: 3
• linux64: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-02-10&endday=2020-02-16&tree=all

Comment 18

[Intermittent Failures Robot]

21 failures in 4045 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 21

Platform breakdown:

• windows10-64: 12
• macosx1014-64: 4
• linux64: 4
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-02-17&endday=2020-02-23&tree=all

Comment 19

[Intermittent Failures Robot]

12 failures in 5233 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 12

Platform breakdown:

• linux64: 2
• windows10-64: 6
• linux32: 2
• windows10-64-shippable: 1
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-02-24&endday=2020-03-01&tree=all

Comment 20

[Intermittent Failures Robot]

28 failures in 5483 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

This is the #46 most frequent failure this week.

Repository breakdown:

• comm-central: 28

Platform breakdown:

• linux64: 4
• windows10-64: 20
• windows10-64-shippable: 2
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-03-02&endday=2020-03-08&tree=all

Comment 21

[Intermittent Failures Robot]

22 failures in 5336 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 22

Platform breakdown:

• windows10-64: 14
• linux32: 2
• macosx1014-64: 3
• windows10-64-shippable: 1
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-03-09&endday=2020-03-15&tree=all

Comment 22

[Intermittent Failures Robot]

20 failures in 4955 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 20

Platform breakdown:

• windows10-64-shippable: 5
• linux64: 3
• windows10-64: 10
• macosx1014-64: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-03-16&endday=2020-03-22&tree=all

Comment 23

[Intermittent Failures Robot]

23 failures in 4773 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 23

Platform breakdown:

• windows10-64-shippable: 2
• windows10-64: 13
• macosx1014-64: 3
• linux64: 2
• linux32: 2
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-03-23&endday=2020-03-29&tree=all

Comment 24

[Intermittent Failures Robot]

18 failures in 5015 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 17
• comm-beta: 1

Platform breakdown:

• windows10-64: 10
• linux32: 1
• linux64: 3
• windows10-64-shippable: 2
• macosx1014-64: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 25

[Geoff Lankow (:darktrojan)]

Attachment: 1601517-notifications-test-1.diff

Generally, the problems with this test are not that the notification we expect doesn't show up, it's that the notification shows up and has already disappeared by the time we expect it. There's a number of timing variables at play here, not least that some of the faked uploads are set to take 500ms, whether that's a good amount of time or not. With this patch I make the upload continue until told to stop, and ensure that happens after we look for the notification that says an upload is in progress. I also turn off animation of the notification bars (probably unnecessary given the real fix, but hey) and reset a pref that gets set during this test.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1000538be12324bef23f8ed9fb1664463cb6f2ce

Comment 26

[Intermittent Failures Robot]

14 failures in 4823 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 14

Platform breakdown:

• windows10-64: 3
• linux64: 4
• windows7-32: 3
• windows10-64-shippable: 2
• linux32: 1
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1601517&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 27

[Magnus Melin [:mkmelin]]

Comment on attachment 9139916 [details] [diff] [review]
1601517-notifications-test-1.diff

Review of attachment 9139916 [details] [diff] [review]:
-----------------------------------------------------------------

Hoping it will fix it! r=mkmelin

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3758d7aac181
Fix browser_notifications.js by controlling the timing of events. r=mkmelin