1601573 - Context menu for chat-contact-richlistitem is not shown

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1601573_context-menu-chat-contact-richlistitem-fixed.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9113734 [details] [diff] [review]
Bug-1601573_context-menu-chat-contact-richlistitem-fixed.patch

Review of attachment 9113734 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please set up the proper commit message

Comment 3

[Patrick Cloke [:clokep]]

Do we know what caused this regression? (Does this need to be uplifted?)

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Bug-1601573_context-menu-chat-contact-richlistitem-fixed-1.patch

Comment 5

[Khushil Mistry [:khushil324]]

(In reply to Patrick Cloke [:clokep] from comment #3)

Do we know what caused this regression? (Does this need to be uplifted?)

I couldn't find any regression as aXulMenu.triggerNode was working previously. Some changes from MC must have caused this.
Looking at the code, I think we need it for beta uplift.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/73aab51bd41d
Resolved context menu for chat-contact and chat-imconv richlistitems. r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

Looks like you set the wrong Target Milestone. Maybe that's the reason the beta uplift was missed.

Comment 8

[Geoff Lankow (:darktrojan)]

72.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4c0ded168a1f27f2697dab8b1e950c93358ebab3