Test Snippets do not generate telemetry events for any interactions if triggered via AS router
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | verified |
People
(Reporter: ppop, Assigned: nanj)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
[Affected Platforms]:
- All Windows
- All Mac
- All Linux
[Affected Versions]:
- Firefox Nightly 73.0a1, Build ID 20191205094649
- Firefox Beta 72.0b2, Build ID 20191203141951
[Prerequisites]:
- The "browser.ping-centre.log" pref is set to "true".
- The "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref is set to "true".
- The browser console is opened.
[Steps to reproduce]:
- Open the browser with the profile from prerequisites and navigate to the "about:home#devtools" page.
- Click the "Show" button from the "SIMPLE_TEST_1" message.
- Observe the console output.
[Expected result]:
- An IMPRESSION telemetry ping is displayed in the browser console.
[Actual result]:
- The "Unknown ping type for ASRouter telemetry" error is displayed.
[Regression Range]:
- I've ran a regression check using mozregression and found the following pushlog that leads to a metabug, it is possible that the issue was introduced by the telemetry migration tracked in bug 1585147.
- Last good revision: 85aa4fa5722bdcb6e0d13f29951772d3c7806e42
- First bad revision: 40a815ecfbe3b248bedafdba52851b774d31efc8
- Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85aa4fa5722bdcb6e0d13f29951772d3c7806e42&tochange=40a815ecfbe3b248bedafdba52851b774d31efc8
[Notes]:
- Only testing snippets are affected, the issue is not reproducible with live snippets.
- This issue is also reproducible for the CLICK and BLOCKED events.
- The "Unknown ping type for ASRouter telemetry" error is displayed when triggering and dismissing the snippet.
- I have attached a screenshot of the console output:
Updated•4 years ago
|
Comment 1•4 years ago
|
||
The bug identified in the regression made some changes to the telemetry pipeline and the list of prefs that need to be enabled is different.
Here's the list of prefs https://docs.google.com/document/d/1oV-88Oilc-uIr9239Hqj3tFqWKQBsn6QwN6ub0DhZm8/edit#
Please reopen if you find other issues.
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by najiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/127801c9ada5 Enable telemetry for the local Snippets message provider r=andreio
Comment 4•4 years ago
|
||
bugherder |
Comment 5•4 years ago
|
||
Does this need a Beta uplift request?
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
Does this need a Beta uplift request?
No, we don't want to uplift this. Thanks!
Comment 7•4 years ago
|
||
I have verified that the issue is no longer reproducible on Firefox Nightly 73.0a1 (Build ID 20191215214948) using Win 10, Mac 10.14 and Linux Debian 9.
The telemetry pings are sent for test snippets triggered from "about:home#devtools" page. I've also verified CLICK_BUTTON and BLOCK events.
Description
•