Closed Bug 1601848 Opened 6 years ago Closed 6 years ago

Several immutability problems in recurrence components

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 73.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

1601848-recurrence-mutability.diff
7.57 KB, patch
Fallen
: review+
Details | Diff | Splinter Review

Working on some tests, I noticed I could change some things about objects that should be immutable. I dug deeper:

  • calRecurrenceDate throws Cr.NS_ERROR_OBJECT_IS_MUTABLE which isn't a thing, should be Cr.NS_ERROR_OBJECT_IS_IMMUTABLE
  • calRecurrenceRule in both backends skip checking if they are mutable before changing
Attachment #9114033 - Flags: review?(philipp)
Version: unspecified → Trunk
Attachment #9114033 - Flags: review?(philipp) → review+
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0660d7e0fdfc
Enforce immutability in recurrenceRule and recurrenceDate; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: