Move crates that are developed out-of-tree to being vendored.
Categories
(Firefox Build System :: General, task, P2)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(4 files, 2 obsolete files)
There are at least three crates that aren't vendored but are actually developed out of tree.: gfx/wgpu, media/libcubeb/cubeb-coreaudio-rs and media/libcubeb/cubeb-pulse-rs. That is a source for confusion when we need to update dependencies to flatten the overall ecosystem of crates we use (e.g. bug 1587468, bug 1563925, etc.).
They should be moved out of these in-tree-looking locations, and be vendored instead.
One complication to vendoring, though, is that they don't all contain licensing information in Cargo.toml, filed as PRs in the relevant crates:
As a testament of the confusion, I present to you exhibit A: bug 1601732 touched gfx/wgpu/wgpu-core/Cargo.toml, where I'm as guilty as Emilio for having overseen it. I opened https://github.com/gfx-rs/wgpu/pull/397.
|
Assignee | |
Comment 1•5 years ago
|
||
This technically breaks mach vendor rust because of the missing
licenses, but this will be fixed subsequently.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
This technically breaks mach vendor rust because of the missing
licenses, but this will be fixed subsequently.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Note this downgrades the smallvec dependency because bug 1601732 touched
the in-tree Cargo.toml. This will be restored with the update that
follows.
This also technically breaks mach vendor rust because of the missing
licenses, but this will be fixed in the same update.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Comment 7•5 years ago
|
||
My understanding is that wgpu is no longer developed out of tree.
|
||
Comment 8•5 years ago
•
|
||
D56160 will import a patch to fix racing issues in cubeb, so I am going to make this p2.
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/11ccdc6bb029 Vendor cubeb-coreaudio. r=padenot https://hg.mozilla.org/integration/autoland/rev/1ba538da6c15 Vendor cubeb-pulse-rs. r=kinetik https://hg.mozilla.org/integration/autoland/rev/7ef710d977a0 Update cubeb-coreaudio to 5fcbd99e1b7356be1efcdc41654d495bd4c71c8c. r=padenot https://hg.mozilla.org/integration/autoland/rev/b38e55cf44e7 Update cubeb-pulse-rs to 8069f8f4189982e0b38fa6dc8993dd4fab41f728. r=kinetik
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/11ccdc6bb029
https://hg.mozilla.org/mozilla-central/rev/1ba538da6c15
https://hg.mozilla.org/mozilla-central/rev/7ef710d977a0
https://hg.mozilla.org/mozilla-central/rev/b38e55cf44e7
Description
•