1602069 - Enable ESLint rule no-undef for js and html files in accessible/tests/mochitest/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Mark Banner (:standard8)]

We should work on enabling no-undef for all of accessible/tests/mochitest/ as it is currently disabled.

In doing this I found bug 1602031, which is an error in a test, so it is definitely worth it.

Currently I'm just doing this for js and html files, as ESLint isn't always automatically picking up globals for xhtml files (bug 1602066).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1602069 - Enable ESLint no-undef rule for accessible/test/mochitest js files. r?jamie

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1602069 - Enable ESLint no-undef rule for accessible/test/mochitest html files. r?jamie

Depends on D56230

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b947578cd967fca8c4349009a0e8a3854e185a

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Mark Banner (:standard8) from comment #0)

We should work on enabling no-undef for all of accessible/tests/mochitest/ as it is currently disabled.

In doing this I found bug 1602031, which is an error in a test, so it is definitely worth it.

yeah, once in a while linting catches real bugs, but it also makes code nicer and consistent, so +1 for doing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61a83433f701
Enable ESLint no-undef rule for accessible/test/mochitest js files. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/84fddf1ffad6
Enable ESLint no-undef rule for accessible/test/mochitest html files. r=Jamie

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/61a83433f701
https://hg.mozilla.org/mozilla-central/rev/84fddf1ffad6