1602114 - Hoist ScriptSourceObject to ParseInfo

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Currently the ScriptSourceObject is allocated deep inside of BytecodeCompiler (sometimes).

We should put ScriptSourceObject into ParseInfo. It's a better home for it.

Longer term, once stencil is done, we will no longer even need the ScriptSourceObject in the parser; currently the ScriptSourceObject is mostly used in the front end to create JSScript/LazyScripts.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1602114 - Don't pass parameterListEnd to CreateScriptSourceObject r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1602114 - Root ScriptSourceObject inside of ParseInfo r?tcampbell

Depends on D58640

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1602114 - Use ParseInfo::sourceObject instead of the newly created script's sourceObject r?tcampbell

Depends on D58641

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1602114 - Remove sourceObjectOut param from CompileGlobalScript r?tcampbell

Depends on D58641

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a14a4d4ba12
Don't pass parameterListEnd to CreateScriptSourceObject r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f27c0adfc0d7
Root ScriptSourceObject inside of ParseInfo r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/869b3fe541d5
Use ParseInfo::sourceObject instead of the newly created script's sourceObject r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/85e35b7ab299
Remove sourceObjectOut param from CompileGlobalScript r=tcampbell

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6a14a4d4ba12
https://hg.mozilla.org/mozilla-central/rev/f27c0adfc0d7
https://hg.mozilla.org/mozilla-central/rev/869b3fe541d5
https://hg.mozilla.org/mozilla-central/rev/85e35b7ab299