Closed
Bug 1602259
Opened 5 years ago
Closed 3 years ago
Support VS2019 for compiling SeaMonkey up to 2.57
Categories
(SeaMonkey :: Build Config, enhancement)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53+ fixed, seamonkey2.57esr affected)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(3 files)
|
8.92 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
1.74 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
8.70 KB,
patch
|
Details | Diff | Splinter Review |
Without this patch compiling SeaMonkey 2.53 with VS2019 is not possible.
Compiling 2.57 works only by chance.
patches for the official gitlab repos only.
Also drop support for VS2015. Old and no longer tested by us.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
2.53 version part 1
Attachment #9114392 -
Flags: review?(iann_bugzilla)
Attachment #9114392 -
Flags: approval-comm-release?
|
|
Assignee | |
Comment 2•5 years ago
|
||
2.53 version part 2
Attachment #9114393 -
Flags: review?(iann_bugzilla)
Attachment #9114393 -
Flags: approval-comm-release?
|
|
Assignee | |
Comment 3•5 years ago
|
||
2.49.x version on top of the esr52 SeaMonkey release branch. No plans to use this.
This supports the VS2017 toolset in VS2019 only because XP support is needed for 2.49.x
Comment on attachment 9114392 [details] [diff] [review] 1602259-1-VS2019-56.patch [Triage Comment] LGTM but I have no way to test r/a=me
Attachment #9114392 -
Flags: review?(iann_bugzilla)
Attachment #9114392 -
Flags: review+
Attachment #9114392 -
Flags: approval-comm-release?
Attachment #9114392 -
Flags: approval-comm-release+
Comment on attachment 9114393 [details] [diff] [review] 1602259-2-VS2019-gyp-56.patch [Triage Comment] LGTM but I have no way to test r/a=me
Attachment #9114393 -
Flags: review?(iann_bugzilla)
Attachment #9114393 -
Flags: review+
Attachment #9114393 -
Flags: approval-comm-release?
Attachment #9114393 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 6•4 years ago
|
||
Fixed in 2.53.1 beta branch:
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/tree/2_53_beta_01
|
|
Assignee | |
Updated•3 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
tracking-seamonkey2.53:
--- → +
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•