Closed Bug 1728988 Opened 3 years ago Closed 2 years ago

Support VS2022 for compiling SeaMonkey up to 2.57

Categories

(SeaMonkey :: Build Config, enhancement)

SeaMonkey 2.53 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.10)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1602259 +++

Compiling SeaMonkey 2.53 and 2.57 with VS2022 preview is not possible.
patches for the official gitlab repos only.

Assignee: nobody → frgrahl

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: VS2022 can not be used
Testing completed (on m-c, etc.): 2.53.10 with VS2022 RC
Risk to taking this patch (and alternatives if risky): build only.
String changes made by this patch: --

Attachment #9245829 - Flags: review?(iann_bugzilla)
Attachment #9245829 - Flags: approval-comm-release?
Attachment #9245829 - Flags: approval-comm-esr60?

Just a hack. gyp is discontinued. With the patch it does not choke on the higher version numbers.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: VS2022 will not wirk
Testing completed (on m-c, etc.): 2.53.10 with VS2022 RC
Risk to taking this patch (and alternatives if risky): build only.
String changes made by this patch: --

Attachment #9245830 - Flags: review?(iann_bugzilla)
Attachment #9245830 - Flags: approval-comm-release?
Attachment #9245830 - Flags: approval-comm-esr60?

Comment on attachment 9245829 [details] [diff] [review]
1728988-1-VS2022-base-25310.patch

[Triage Comment]
Seems logical r/a=me

Attachment #9245829 - Flags: review?(iann_bugzilla)
Attachment #9245829 - Flags: review+
Attachment #9245829 - Flags: approval-comm-release?
Attachment #9245829 - Flags: approval-comm-release+
Attachment #9245829 - Flags: approval-comm-esr60?
Attachment #9245829 - Flags: approval-comm-esr60+

Comment on attachment 9245830 [details] [diff] [review]
1728988-2-VS2022-gyp-25310.patch

[Triage Comment]
Seems logical r/a=me

Attachment #9245830 - Flags: review?(iann_bugzilla)
Attachment #9245830 - Flags: review+
Attachment #9245830 - Flags: approval-comm-release?
Attachment #9245830 - Flags: approval-comm-release+
Attachment #9245830 - Flags: approval-comm-esr60?
Attachment #9245830 - Flags: approval-comm-esr60+
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: