1602317 - Use nicer cbindgen bitflags.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Now that we use C++17, we can use inline const.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1602317 - Switch style system to associated constants-in-body. r=#style

This is closer to the equivalent Rust code.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1602317 - Switch WR bindings to use associated-constants-in-body. r=jrmuizel,nical,Gankro

Now that we have C++17, and thus inline const, we can do this.

Depends on D56306

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1602317 - Update cbindgen to 0.11.1. r=jrmuizel,#style

This includes more bitflag operators, which means we can remove some slightly
ugly code.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1602317 - Remove some useless includes. r=heycam

This also removes some unused members and such, and fixes some missing includes
that they uncover (whoops).

This is needed because some windows headers used in the sandbox redefine STRICT
(which is used by StyleContain) and TRANSPARENT, which is used by some WR
stuff.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1602317 - More reliably workaround some silly windows.h defines. r=nical

I couldn't get some Windows sandbox code to build with the other patch in this
bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c2b364c2133
More reliably workaround some silly windows.h defines. r=nical

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ef150adc153
Remove some useless includes. r=heycam

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b278f7aa894e
Switch style system to associated constants-in-body. r=heycam
https://hg.mozilla.org/integration/autoland/rev/73ea4471a43d
Switch WR bindings to use associated-constants-in-body. r=jrmuizel

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a31b8aefee
Update cbindgen to 0.11.1. r=jrmuizel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/297a4463b26d
Add a missing include in OSReauthenticator to unbust win builds. a=malexandru

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0c2b364c2133
https://hg.mozilla.org/mozilla-central/rev/5ef150adc153
https://hg.mozilla.org/mozilla-central/rev/b278f7aa894e
https://hg.mozilla.org/mozilla-central/rev/73ea4471a43d
https://hg.mozilla.org/mozilla-central/rev/92a31b8aefee
https://hg.mozilla.org/mozilla-central/rev/297a4463b26d