1602320 - Reduce the number of parameters needed to create DocumentChannel/DocumentLoadListener

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Matt Woodrow (:mattwoodrow)]

We currently pass an nsDocShellLoadState in DocumentChannelCreationArgs, but we also pass a lot of other state coming from the originating docshell.

In order to do DocumentChannel creation from the parent-process (bug 1602318), we'll need to be able to do this without reading from any docshell, but we should have a BrowsingContext instead.

I think most of these values fall under one (or more) of a few categories)

• Things that are computed from the nsDocShellLoadState, and need that computation code factored out of docshell.
  ** LoadInfo is mostly this, thought some sub-components may fall under other categories
• Things that are available from the BrowsingContext, or should be.
  ** initiatorType, isActive, isTopLevelDoc, hasNonEmptySandboxingFlags
• Things that could just be statically known
  ** If we current do a process-switch before starting a top-level load, then we'd get a brand new docshell, so some values will be guaranteed to be their default value in this case.
• Things that could be computed in the parent
  ** Async open time, channel id

Comment 1

[Kershaw Chang [:kershaw]]

Hi Nika, it looks like this bug is already done. Can we close this one?
Thanks.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

resolving as fixed