1602371 - Simplify DevTools LocalTabTargetFront

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

I was reviewing the current responsibilities of LocalTabTargetFront in scope of Bug 1579042.

It handles:

• tab events
  • TabClose
  • TabRemotenessChange
  • unload
• local tab getters
  • tab
  • isLocalTab
  • csp
  • contentPrincipal

I think we should try to move most of this to the server. Once we have a TabDescriptorActor in Bug 1579042, it will be the ideal spot to listen to tab events, since it will also run in the parent process. We might keep them in the TabDescriptorFront in a first step, but those events really belong in the server.

In this bug I would like to try some preliminary cleanups:

• remove the "unload" event. This listener is not really documented, it's not clear why we should destroy the target front here?
• remove the csp & contentPrincipal getters. They are only used in one callsite which already has a pointer to the tab
• rename the tab getter to localTab to make is easier to search (and maybe try to remove a few call sites)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1602371 - Stop listening to tab unload in LocalTabTargetFront

It is not clear why tab unload should be listened to on the client, and only destroy the target front.
Tentatively removing to simplify the local tab target.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1602371 - Remove csp and contentPrincipal getters in LocalTabTargetFront

Depends on D56327. Not reason to make target-mixin more complex for this workaround which already has access to the tab object.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1602371 - Rename LocalTabTargetFront tab getter to localTab

Depends on D56330

Renaming the "tab" getter to "localTab" will make it easier to refactor later.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09beec6ec35d
Stop listening to tab unload in LocalTabTargetFront r=ochameau
https://hg.mozilla.org/integration/autoland/rev/8ab51c4822d4
Remove csp and contentPrincipal getters in LocalTabTargetFront r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f8c1648fb4d0
Rename LocalTabTargetFront tab getter to localTab r=ochameau

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/09beec6ec35d
https://hg.mozilla.org/mozilla-central/rev/8ab51c4822d4
https://hg.mozilla.org/mozilla-central/rev/f8c1648fb4d0