1579042 - Introduce TabDescriptors

Status: RESOLVED FIXED

(DevTools :: General, task, P1)

Description

[Yulia Startsev [:yulia]]

Similar to processDescriptors and frameDescriptors, we want to be able to have descriptors for tabs.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1579042 - Rename FrameTargetProxyActor to TabDescriptorActor

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1579042 - migrate TabDescriptorActor to a protocol.js actor

Depends on D49454

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1579042 - Move tab call to getTarget from the server to the client

Depends on D49455

Comment 4

[Chris Peterson [:cpeterson]]

Tracking DevTools bugs for Fission Nightly (M6) milestone

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Rename FrameTargetProxyActor to TabDescriptorActor

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - migrate TabDescriptorActor to a protocol.js actor

depends on D63498

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Move tab call to getTarget from the server to the client

Depends on D63501

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Return threadActor in browsing context form updates

Depends on D63502

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Fix race condition in tests after introducing tab descriptors

Depends on D63503

Fix another test

---

Fix getTab

---

Investigate listTabs issues for about debugger

---

prettier on actors/descriptors/tab

---

Fix race condition in selectRuntime helper after making watchRuntime more async

---

Bail out of listTabs if root front was destroyed

---

Reject tab descriptor update request if the tab is closed

---

Return empty array instead of null when listTabs fails

---

WIP : Do not destroy tab descriptor front on exited event

---

Wait for the toolbox tab to disappear in aboutdebugging target destroyed test

---

Stop using attach in browser_dbg_listtabs-01 because tab targets are automatically attached now

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Test tab descriptor in browser_target_parents.js

Depends on D63504

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1579042 - Remove exit and exited notions from tab descriptor actor

Depends on D63514

Comment 12

[Julian Descottes [:jdescottes]]

Try for the current stack: https://treeherder.mozilla.org/#/jobs?repo=try&revision=55dce64e70f93fc8093bccece17b994531cd7d8e

Comment 13

[Julian Descottes [:jdescottes]]

DAMP comparison: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=cdc90bf1ef41ff2707a4013b40285f2754cce18b&originalSignature=1759151&newSignature=1759151&framework=12&originalRevision=ba5e43db5d71c37d83d184bbaa9971f7aec30c85

• cold.inspector.open.DAMP 5.4% slower
• cold.netmonitor.open.DAMP 2.5% slower
• cold.webconsole.open.DAMP 4.2% slower
• complicated.netmonitor.open.DAMP 2.6% slower
• simple.styleeditor.open.DAMP 3.8% slower
• simple.webconsole.close.DAMP 6.8% slower
• simple.webconsole.open.DAMP 2.6% slower

Comment 14

[Julian Descottes [:jdescottes]]

I think I have most comments addressed. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e60b6c70001d9e77ee22ff99ab999e4621dedab

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2640fedd4b7d
Rename FrameTargetProxyActor to TabDescriptorActor r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4001ef023857
migrate TabDescriptorActor to a protocol.js actor r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7209387fd76b
Move tab call to getTarget from the server to the client r=ochameau
https://hg.mozilla.org/integration/autoland/rev/15ab7909725f
Return threadActor in browsing context form updates r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b70997375b03
Fix race condition in tests after introducing tab descriptors r=ochameau
https://hg.mozilla.org/integration/autoland/rev/545bbdbc329e
Test tab descriptor in browser_target_parents.js r=ochameau

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2640fedd4b7d
https://hg.mozilla.org/mozilla-central/rev/4001ef023857
https://hg.mozilla.org/mozilla-central/rev/7209387fd76b
https://hg.mozilla.org/mozilla-central/rev/15ab7909725f
https://hg.mozilla.org/mozilla-central/rev/b70997375b03
https://hg.mozilla.org/mozilla-central/rev/545bbdbc329e

Comment 17

[Cosmin Sabou [:CosminS]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1608353#c11

Comment 18

[Julian Descottes [:jdescottes]]

There is already a ni? in the other bug.