1602774 - error: definition of implicit copy constructor for 'RangedPtr<const char16_t>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

building with clang trunk

In file included from Unified_cpp_certverifier0.cpp:11:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/security/certverifier/CertVerifier.cpp:7:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/security/certverifier/CertVerifier.h:30:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/BasePrincipal.h:10:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/nsJSPrincipals.h:9:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/jsapi.h:16:
In file included from /var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/Range.h:10:
/var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/RangedPtr.h:151:17: error: definition of implicit copy constructor for 'RangedPtr<const char16_t>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  RangedPtr<T>& operator=(const RangedPtr<T>& aOther) {
                ^
/var/lib/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/Range.h:20:7: note: in implicit copy constructor for 'mozilla::RangedPtr<const char16_t>' first required here
class Range {
      ^

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1602774 - add a copy constructor to RangedPtr; r=sylvestre

Doing this avoids warnings about implicitly-declared copy constructors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42aedd49b347
add a copy constructor to RangedPtr; r=sylvestre

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/42aedd49b347