1602813 - Crash in [@ objc_exception_throw | -[NSObject doesNotRecognizeSelector:]]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[[:philipp]]

This bug is for crash report bp-fccca452-1b9e-461b-b21f-dbcee0191210.

Top 10 frames of crashing thread:

0 XUL CrashReporter::TerminateHandler toolkit/crashreporter/nsExceptionHandler.cpp:1457
1 libc++abi.dylib std::__terminate 
2 libc++abi.dylib __cxa_throw 
3 libobjc.A.dylib objc_exception_throw 
4 CoreFoundation -[NSObject doesNotRecognizeSelector:] 
5 CoreFoundation ___forwarding___ 
6 CoreFoundation __forwarding_prep_0___ 
7 XUL mozilla::gl::GLContextCGL::MigrateToActiveGPU gfx/gl/GLContextProviderCGL.mm:171
8 XUL nsChildView::PreRender widget/cocoa/nsChildView.mm:1711
9 XUL mozilla::layers::LayerManagerComposite::UpdateAndRender gfx/layers/composite/LayerManagerComposite.cpp:641

these crashes are spiking up in the 72.0 beta cycle from users still on osx 10.9

Comment 1

[Miko Mynttinen]

Markus, can we somehow restrict this feature to OSX > 10.9 (or whatever the appropriate version is)?

Comment 2

[Markus Stange [:mstange]]

It's this method, which is indeed only available on 10.10 and up: https://developer.apple.com/documentation/appkit/nsopenglpixelformat/1436109-getvalues?language=objc

Comment 3

[Markus Stange [:mstange]]

No, wait, it says 10.0 and up. It must be some other method.

Comment 4

[Markus Stange [:mstange]]

It's -[NSOpenGLContext pixelFormat]. This would have been a lot faster to figure out if crash reports had inline callstacks. Instead, I had to find the crashing line by manually downloading XUL.dSYM and using addr2line, similarly to what I did in bug1599861 comment 3.

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1602813 - Stop calling -[NSOpenGLContext pixelFormat] because it's not available on 10.9. Instead, inline CreateWithFormat into this callsite. r=jrmuizel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b3e5d860458
Stop calling -[NSOpenGLContext pixelFormat] because it's not available on 10.9. Instead, inline CreateWithFormat into this callsite. r=jrmuizel

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2b3e5d860458

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 9114936 [details]
Bug 1602813 - Stop calling -[NSOpenGLContext pixelFormat] because it's not available on 10.9. Instead, inline CreateWithFormat into this callsite. r=jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Crashes for macOS 10.9 users
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: 1. Run Firefox on 10.9 on a machine with multiple GPUs.

2. Use gfxCardStatus from https://gfx.io/ to switch to the discrete GPU.
3. Firefox shouldn't crash.
   It's not really worth spending time verifying this; we will see based on the crash rate whether this has been fixed.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is simple
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9114936 [details]
Bug 1602813 - Stop calling -[NSOpenGLContext pixelFormat] because it's not available on 10.9. Instead, inline CreateWithFormat into this callsite. r=jrmuizel

macos 10.9 crash fix, approved for 72.0b6

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/467f2a42232f

Comment 11

[[:philipp]]

we still get some crashes in 72.0b6

Comment 13

[Markus Stange [:mstange]]

Oops. We call the same function in a different place as well, I missed that. Going to make another patch.

Comment 14

[Markus Stange [:mstange]]

Attachment: Bug 1604633 - Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

Comment 15

[Phabricator Automation]

Comment on attachment 9116544 [details]
Bug 1604633 - Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

Revision D57555 was moved to bug 1604633. Setting attachment 9116544 [details] to obsolete.

Comment 16

[Markus Stange [:mstange]]

I've filed bug 1604633 on the other call and moved the follow-up patch there.