1604633 - Crash in [@ objc_exception_throw | -[NSObject doesNotRecognizeSelector:]], take 2

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

+++ This bug was initially created as a clone of Bug #1602813 +++

The patch in bug 1602813 didn't fix the crash properly. It removed 1 out of 2 calls, the other one still remains. We still crash on macOS 10.9 every time the active GPU changes.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1604633 - Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f333efd51fbe
Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 9116546 [details]
Bug 1604633 - Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Firefox will crash on macOS 10.9 every time the active GPU changes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: See bug 1602813 comment 8
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is simple
• String changes made/needed:

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f333efd51fbe

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9116546 [details]
Bug 1604633 - Stop calling -[NSOpenGLContext pixelFormat] on 10.9, take 2. r=jrmuizel

mac crash fix, approved for 72.0b9

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ae632228a6e