Closed
Bug 1603099
Opened 5 years ago
Closed 5 years ago
Remove unused declaration in VideoFrameContainer.cpp
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox74 fixed)
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: atul.ramkrishnan97, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1600554 +++
Filling as a good first bug to learn workflows.
These two lines seem to be unused:
https://searchfox.org/mozilla-central/source/dom/media/VideoFrameContainer.cpp#19-20
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by clang diag https://clang.llvm.org/docs/DiagnosticsReference.html#wunused-variable
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → atul.ramkrishnan97
|
||
Comment 2•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:atul.ramkrishnan97, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(atul.ramkrishnan97)
|
Reporter | |
Comment 3•5 years ago
|
||
Looks like we didn't land it, I just did!
Flags: needinfo?(atul.ramkrishnan97)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95df45e27189
Remove unused declaration in VideoFrameContainer.cpp r=jya
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•