Support remote frame targets in the omniscient browser toolbox
Categories
(DevTools :: Framework, task, P3)
Tracking
(firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(3 files, 1 obsolete file)
After landing Bug 1565200, we should be able to inspect remote frames in the inspector when using the Omniscient Browser Toolbox.
To enable this we need to:
- update the FrameDescriptorActor to use the JsWindowActor connector for remote frames (https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/devtools/server/actors/descriptors/frame.js#38-44)
- update isRemoteFrame to handle content iframes (https://searchfox.org/mozilla-central/source/devtools/shared/layout/utils.js#852)
Assignee | ||
Comment 1•1 year ago
|
||
Depends on D51130
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D56347
This preference cannot be set dynamically, this should not have any impact.
And since this was using the pushPref helper, it was cleaned up after the test anyway.
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
Depends on D56347
Assignee | ||
Comment 4•1 year ago
|
||
Updated•1 year ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10769c72ba39 Expose FrameLoader::IsRemoteFrame() to chrome privileged JS r=farre https://hg.mozilla.org/integration/autoland/rev/56392b65466b Support remote frame targets in the omniscient browser toolbox r=ochameau https://hg.mozilla.org/integration/autoland/rev/ef521f6b57ea Add a test to expand remote frames in the markup view from the Omniscient Browser Toolbox r=ochameau
Comment 7•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/10769c72ba39
https://hg.mozilla.org/mozilla-central/rev/56392b65466b
https://hg.mozilla.org/mozilla-central/rev/ef521f6b57ea
Comment 8•1 year ago
|
||
Backed out for dt leaks at mozilla::net::AddrInfo::AddrInfo
Backout link: https://hg.mozilla.org/integration/autoland/rev/c1f9a4f1ad5b28d8122f8778c1c5c189f336a4c4
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281741423&repo=autoland&lineNumber=1798
Assignee | ||
Comment 9•1 year ago
|
||
Argh I forgot that ToolboxTask is not working on asan
Comment 10•1 year ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d9474a4c873 Expose FrameLoader::IsRemoteFrame() to chrome privileged JS r=farre https://hg.mozilla.org/integration/autoland/rev/2c6c0127f146 Support remote frame targets in the omniscient browser toolbox r=ochameau https://hg.mozilla.org/integration/autoland/rev/4f93f06f71b8 Add a test to expand remote frames in the markup view from the Omniscient Browser Toolbox r=ochameau
Comment 11•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9d9474a4c873
https://hg.mozilla.org/mozilla-central/rev/2c6c0127f146
https://hg.mozilla.org/mozilla-central/rev/4f93f06f71b8
Description
•