1565200 - Use JSWindowActor API instead of message manager in DebuggerServer.connectToFrame

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Alexandre Poirot [:ochameau]]

See bug 1565197.

This bug is about focusing on DebuggerServer.connectToFrame:
https://searchfox.org/mozilla-central/source/devtools/server/main.js#658
And see from there if we can replace all message manager usages that unroll from this without refactoring the DevTools universe completely.

I tend to believe that setupInParent should be automagically working without much specifics.

Note that this work should ignore the fact that we could have remoted iframes.
We can pass allFrame: false to ChromeUtils.registerWindowActor.
The focus here should be to convert to the new API sooner than later.

I think that using this API would help support process switching of tabs.
This is a side effect of Fission, where there isn't necessarily remoted iframes.
When you navigate from one URL to another, the tab may load the two documents in distinct process and we would have to support that nicely. For now, the toolbox closes and reopen...

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1565200 - Split main.js in debugger-server and debugger-server-connection

I would like to do some cleanup in main.js
After this initial split I would also like to extract the connectToFrame/connectToWorker blocks
But before I go too deep into this I'd like to check if this seems ok with you and if it doesn't conflict
with too many other inflight patches.

Comment 2

[Phabricator Automation]

Comment on attachment 9083669 [details]
Bug 1565200 - Split main.js in debugger-server and debugger-server-connection

Revision D41009 was moved to bug 1572390. Setting attachment 9083669 [details] to obsolete.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1565200 - Add frame connector relying on JsWindowActor instead of message manager

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1565200 - Add warning message when using JS Window Actor instead of message manager

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1565200 - Add frame connector relying on JsWindowActor instead of message manager

Depends on D51136

Comment 6

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 7

[Chris Peterson [:cpeterson]]

Making DevTools Fission-compatible is a prerequisite for enabling Fission in Nightly (M6).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcfe51a156b9
Add frame connector relying on JsWindowActor instead of message manager r=ochameau

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/dcfe51a156b9