1603226 - Enable signon.userInputRequiredToCapture.enabled and prompt when field values differ from their defaultValue

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1388674 introduced the signon.userInputRequiredToCapture.enabled pref, but left it defaulted off. If we check for user input or fields where their .value !== .defaultValue, this should minimize the regression risk and allow us to turn that pref on by default.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1603226 - enable signon.userInputRequiredToCapture.enabled by default, and allow capture when any field value !== its defaultValue. r?MattN

Comment 2

[Sam Foster [:sfoster] (he/him)]

try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5b914e27e9797d1349b0355cd23d91410c002ff

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ef1a9045a64
enable signon.userInputRequiredToCapture.enabled by default, and allow capture when any field value !== its defaultValue. r=MattN

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8ef1a9045a64

Comment 5

[Timea Cernea [:tbabos][inactive]]

Hey Sam,
The pref is indeed enabled by default on the latest Nightly 73.0a1 (2020-01-05) (64-bit), however it doesn't work with Testcase 1: Username and password fields filled by JS from Bug 1388674. The save prompt will be displayed even if the fields were not edited. I attached a log to the mentioned bug, hope it helps.
Won't NI? you here since I already did in the other Bug 1388674 with the same info.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Clarification were offered in Bug 1388674 regarding the expected behavior.
The pref "signon.userInputRequiredToCapture.enabled" is enabled by default on Windows 10, MacOS 10.14 and Ubuntu 18.04.