1620482 - Don't treat non-user-triggered autofill into login forms as an edit for capture

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Sam Foster [:sfoster] (he/him)]

When signon.passwordEditCapture.enabled is true, autofilling a form with a saved login results in a PasswordEditedOrGenerated message being sent to the parent process. This is wrong in a couple of ways:

• The form is flagged as user-modified, so bypasses the measures implemented in bug 1388674 in this case.
• LoginManagerParent gets the message and has to determine if a doorhanger should be shown. This is invisible to the user but messes up a lot of tests...
• The dispatch of the PasswordEditedOrGenerated breaks an assumption in a lot of tests that FormProcessed will happen first, resulting in intermittent failure.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1620482 - Don't treat non-user-triggered autofill into login forms as an edit. r?MattN

• Dont flag a form as user-modified when the input is from autofilling a login
• Avoid sending PasswordEditedOrGenerated messages to the parent from non-user-modified forms.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaedc7cf346b
Don't treat non-user-triggered autofill into login forms as an edit. r=MattN

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/aaedc7cf346b

Comment 4

[Timea Cernea [:tbabos][inactive]]

Verified-fixed for Firefox Beta 75.0b9 (after setting signon.passwordEditCapture.enabled to true) and on Latest Nightly 76.0a1 (2020-03-26) on Windows 10, Mac OS 10.13 and Ubuntu 16.04.

Autofilled credentials on login forms are not recorded as an edit for capture -> the dismissed doorhanger is not displayed.