Closed Bug 1620482 Opened 1 year ago Closed 1 year ago

Don't treat non-user-triggered autofill into login forms as an edit for capture

Categories

(Toolkit :: Password Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla75
Tracking Status
firefox75 --- verified disabled
firefox76 --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [passwords:capture-UI])

Attachments

(1 file)

When signon.passwordEditCapture.enabled is true, autofilling a form with a saved login results in a PasswordEditedOrGenerated message being sent to the parent process. This is wrong in a couple of ways:

  • The form is flagged as user-modified, so bypasses the measures implemented in bug 1388674 in this case.
  • LoginManagerParent gets the message and has to determine if a doorhanger should be shown. This is invisible to the user but messes up a lot of tests...
  • The dispatch of the PasswordEditedOrGenerated breaks an assumption in a lot of tests that FormProcessed will happen first, resulting in intermittent failure.
  • Dont flag a form as user-modified when the input is from autofilling a login
  • Avoid sending PasswordEditedOrGenerated messages to the parent from non-user-modified forms.
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaedc7cf346b
Don't treat non-user-triggered autofill into login forms as an edit. r=MattN
Blocks: 1619030
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

Verified-fixed for Firefox Beta 75.0b9 (after setting signon.passwordEditCapture.enabled to true) and on Latest Nightly 76.0a1 (2020-03-26) on Windows 10, Mac OS 10.13 and Ubuntu 16.04.

Autofilled credentials on login forms are not recorded as an edit for capture -> the dismissed doorhanger is not displayed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.