1603356 - Enable Eager evaluation in Nightly

Status: VERIFIED FIXED

(DevTools :: Console, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Enable Eager evaluation in Nightly as soon as it's ready for internal testing.

The pref is: devtools.webconsole.input.eagerEvaluation

Honza

Comment 1

[Sebastian Zartner [:sebo]]

This should be mentioned at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features, at least.

Sebastian

Comment 2

[Jason Laster [:jlast]]

Attachment: Bug 1603356 - Enable Eager evaluation in Nightly. r=nchevobbe

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c414004b82a
Enable Eager evaluation in Nightly. r=nchevobbe

Comment 4

[Razvan Maries]

Backed out for dt failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=284714703&resultStatus=testfailed%2Cbusted%2Cexception&revision=7c414004b82aa22f57278e2adbaff9244fbcac6e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284714703&repo=autoland&lineNumber=60463

Backout: https://hg.mozilla.org/integration/autoland/rev/f1752600458730c36ba2231955f9b6ce162b26b2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f49107726254
Enable Eager evaluation in Nightly. r=nchevobbe

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_dbg-log-points.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/04ada1c4f921220de2b708aef66748e1394354a2
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284967214&repo=autoland&lineNumber=24979

Comment 7

[Jason Laster [:jlast]]

Attachment: Bug 1603356 - Enable Eager evaluation in Nightly. r=nchevobbe

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525336d7af51
Enable Eager evaluation in Nightly. r=nchevobbe

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/525336d7af51

Comment 10

[Cristian Fogel [:cfogel]]

As far as Nightly builds go, confirming with current nightly builds that the pref is enabled by default.
Marking verified with 75.0a1 (2020-02-20) - Windows 10, macOS 10.13, Ubuntu 19.04.

Comment 11

[gwarser]

mozregression pointed me here - https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4abd12f068cf2ffcc4beb6f652ab8a8995443cc3&tochange=525336d7af5157b773fb6ab51777f5bd70ec1138

This pref causes uBlock Origin internal benchmark to return ~10 times worse results:

devtools.webconsole.input.eagerEvaluation set to true:

µBlock.staticNetFilteringEngine.benchmark();
[uBO] Loading benchmark dataset... console.js:26:40
[uBO] Parsing benchmark dataset... console.js:26:40
[uBO] Benchmarking staticNetFilteringEngine.matchString()... console.js:26:40
[uBO] Evaluated 230363 requests in 73887 ms console.js:26:40
[uBO] 	Average: 0.321 ms per request console.js:26:40

devtools.webconsole.input.eagerEvaluation set to false:

µBlock.staticNetFilteringEngine.benchmark();
[uBO] Benchmarking staticNetFilteringEngine.matchString()... console.js:26:40
Promise { <state>: "pending" }
[uBO] Evaluated 230363 requests in 8450 ms console.js:26:40
[uBO] 	Average: 0.037 ms per request console.js:26:40

How to run this benchmark:

• fresh Nightly build
• install latest dev version of uBO from https://github.com/gorhill/uBlock/releases/ (it's easier to setup that way, can also be run in older uBO versions with more effort - custom build)
• open uBO Preferences (for ex. from about:addons, "..." button menu)
• enable option "I am an advanced user (required reading) "
• click small gear icon after "I am an advanced user (required reading) " string
• in new window set:
  • benchmarkDatasetURL to https://cdn.cliqz.com/adblocking/requests_top500.json.gz
  • consoleLogLevel to info - to actually see something printed in console
• open about:devtools-toolbox?type=extension&id=uBlock0%40raymondhill.net
• run in console: µBlock.staticNetFilteringEngine.benchmark();

Toggling devtools.webconsole.input.eagerEvaluation requires devtools-toolbox to be reloaded.

Comment 12

[:Harald Kirschner :digitarald]

Could you file a follow-up regression bug with those details (New/Clone … > that is regressed by this bug)?

I'd be curious to hear if ublock extension depends on any console APIs and if devtools is open at all during benchmarks.

Comment 13

[gwarser]

https://bugzilla.mozilla.org/show_bug.cgi?id=1617666