1611130 - Perma devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/ when Gecko merges to Beta on on 2020-02-10

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Cristina Coroiu [:ccoroiu]]

[Tracking Requested - why for this release]:

Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ebae107ff41cb9dd9b4aa92eaae0c5d6a50aa82d&searchStr=devtools&selectedJob=286121033

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286121033&repo=try&lineNumber=25654

[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js | output node has no height -
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - Buffered messages finished
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js:29 - TypeError: eagerNode is null
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - Stack trace:
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - calculateAppHeight@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js:29:1
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - @chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_in_line_layout.js:35:5
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - Leaving test bound
[task 2020-01-23T11:24:39.835Z] 11:24:39 INFO - GECKO(2160) | [Child 2165: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x10fc773e0) [pid = 2165] [serial = 105] [outer = 0x0] [url = https://example.com/browser/devtools/client/webconsole//test/browser/test_hsts-invalid-headers.sjs?multipleMaxAge]
[task 2020-01-23T11:24:39.836Z] 11:24:39 INFO - GECKO(2160) | [Child 2165: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x10fc78100) [pid = 2165] [serial = 114] [outer = 0x0] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-console.html]
[task 2020-01-23T11:24:39.836Z] 11:24:39 INFO - GECKO(2160) | [Parent 2160, DOM Worker] WARNING: '!mWorkerPrivate->AddWorkerRef(this, aStatus)', file /builds/worker/workspace/build/src/dom/workers/WorkerRef.cpp, line 80
[task 2020-01-23T11:24:40.820Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x1453d0400) [pid = 2163] [serial = 184] [outer = 0x0] [url = about:blank]
[task 2020-01-23T11:24:40.820Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x1453d4000) [pid = 2163] [serial = 189] [outer = 0x0] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-iframe-wrong-hud-iframe.html]
[task 2020-01-23T11:24:40.821Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x144672c00) [pid = 2163] [serial = 187] [outer = 0x0] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-iframe-wrong-hud.html]
[task 2020-01-23T11:24:40.822Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x142f0a000 == 2 [pid = 2163] [id = {da3269d5-dbab-c845-9feb-3280bce0da3d}] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-iframe-wrong-hud-iframe.html]
[task 2020-01-23T11:24:40.822Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x10b5ae800 == 1 [pid = 2163] [id = {560fdb90-199b-e147-b1ac-eff53a7ae8bf}] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-iframe-wrong-hud.html]
[task 2020-01-23T11:24:40.955Z] 11:24:40 INFO - GECKO(2160) | [Child 2163: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x14545e6a0) [pid = 2163] [serial = 191] [outer = 0x0] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-iframe-wrong-hud-iframe.html]
[task 2020-01-23T11:24:41.220Z] 11:24:41 INFO - GECKO(2160) | [Parent 2160: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11d7f0000 == 9 [pid = 2160] [id = {512ffead-a036-0846-a46b-2c074f1fa160}] [url = about:devtools-toolbox]
[task 2020-01-23T11:24:41.340Z] 11:24:41 INFO - Removing tab.
[task 2020-01-23T11:24:41.341Z] 11:24:41 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-01-23T11:24:41.384Z] 11:24:41 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-01-23T11:24:41.384Z] 11:24:41 INFO - GECKO(2160) | console.warn: "IGNORED REDUX ACTION:" ({type:"AUTOCOMPLETE_CLEAR"})
[task 2020-01-23T11:24:41.386Z] 11:24:41 INFO - GECKO(2160) | [Parent 2160, Main Thread] WARNING: '!inner', file /builds/worker/workspace/build/src/dom/ipc/JSWindowActorService.cpp, line 181
[task 2020-01-23T11:24:41.386Z] 11:24:41 INFO - Tab removed and finished closing
[task 2020-01-23T11:24:41.425Z] 11:24:41 INFO - GECKO(2160) | [Parent 2160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (0x130c11020) [pid = 2160] [serial = 426] [outer = 0x0] [url = chrome://devtools/content/webconsole/index.html]
[task 2020-01-23T11:24:41.425Z] 11:24:41 INFO - GECKO(2160) | [Parent 2160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (0x11fcbc2e0) [pid = 2160] [serial = 423] [outer = 0x0] [url = about:devtools-toolbox]
[task 2020-01-23T11:24:41.425Z] 11:24:41 INFO - GECKO(2160) | [Parent 2160: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11ee13000 == 8 [pid = 2160] [id = {a0aebcf4-8fa3-6745-8ed3-5a3128137915}] [url = chrome://devtools/content/webconsole/index.html]

Comment 1

[Jason Laster [:jlast]]

Just looked into this, and it is a fairly easy fix.

It looks like the test should force the eager eval pref on, so that it is version independent.

Comment 2

[Jason Laster [:jlast]]

Attachment: Bug 1611130 - fix browser_webconsole_in_line_layout.js. r=nchevobbe

Comment 3

[Stefan Hindli [:stefan_hindli]]

Importing the patch in today's betasim resolved the failures:

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=286528159&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=99dac234054854bcb3eee882bf692630957d6cc9&searchStr=devtools

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64577002eef9
fix browser_webconsole_in_line_layout.js. r=nchevobbe

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/64577002eef9

Comment 6

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=286833987&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=49939065bcfc315ff090a2cb773ac805904ddbb2&searchStr=devtools