Moving files lead to a weird double move in Phabricator
Categories
(Conduit :: moz-phab, defect, P1)
Tracking
(Not tracked)
People
(Reporter: calixte, Unassigned)
References
Details
(Keywords: conduit-triaged)
Attachments
(1 obsolete file)
I just moved a file using hg mv.
The hg status before pushing was:
M build/build-clang/clang-7-linux64.json
M build/build-clang/clang-android.json
M build/build-clang/clang-linux64-aarch64-cross.json
M build/build-clang/clang-linux64-cross.json
M build/build-clang/clang-linux64.json
M build/build-clang/clang-macosx64.json
A build/build-clang/critical_section_on_gcov_flush-rG02ce9d8ef5a8.patch
R build/build-clang/rG02ce9d8ef5a8.patch
So everything looked fine, but in Phabricator I get:
https://phabricator.services.mozilla.com/D56945
where this is a kind of "cyclic move".
|
||
Comment 1•5 years ago
|
||
It looks like the same move was reported twice, from both sides (see the arrows direction).
I'm wondering how moz-phab patch would act on this.
|
Reporter | |
Comment 2•5 years ago
|
||
Probably, :gsvelto met the same kind of issue yesterday:
https://bugzilla.mozilla.org/show_bug.cgi?id=1594344#c15
|
|
||
Comment 3•5 years ago
|
||
|
|
||
Comment 4•5 years ago
|
||
It seemed like the error appeared after a switch to no-arc by default.
Switched back to the Arc until this is fixed. :(
I'll soon post the steps to reproduce.
|
|
||
Comment 5•5 years ago
|
||
The behavior for hg move is the same with or without Arcanist.
I believe this is fine as long as the patch is landed properly.
moz-phab patch is working fine.
The :gsvelto change was about hg copy and it's a bug marked as P1.
I'm reporting it in a different bug for clarity.
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9115770 [details]
Bug 1603447 - Back to the Arcanist by default
Revision D57110 was moved to bug 1604097. Setting attachment 9115770 [details] to obsolete.
Description
•