1604097 - Incorrect recognizing of a file being copied in Mercurial.

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P1)

Description

[Piotr Zalewa [:zalun]]

Steps to reproduce a copy error (an a dev site):

$  hg clone https://hg.mozilla.org/automation/phabricator-qa-dev/ 
$ hg copy TEST TEST2
$ hg commit -m "Bug 1 - copy"
$ moz-phab --no-arc .

Expected

https://phabricator-dev.allizom.org/D1633
(Observable by performing a submit using Arcanist moz-phab .)
"TEST This file was copied to TEST2."
"TEST2 This file was copied from TEST."

Observed

https://phabricator-dev.allizom.org/D1631
"TEST This file was moved to TEST2."
"TEST2 This file was moved from TEST."

Notes

An issue with hg move was initially reported in bug 1603447 by :calixte.
He mentioned a similar issue reported by :gsvelto in https://bugzilla.mozilla.org/show_bug.cgi?id=1594344#c15
MozPhab is now reverted to a state where the default action is to use Arcanist.

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: Bug 1603447 - Back to the Arcanist by default

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Bug 1604097 - recognize copying with `hg copy` r=mhentges

Previously all changing name of the file was treated as a move.
This patch is checking if od filename is removed - if so - it is a move
else it's a copy.

Comment 4

[Piotr Zalewa [:zalun]]

Attachment: Bug 1604097 - Bring back no arc by default.

Comment 5

[Piotr Zalewa [:zalun]]

Attachment: Bug 1604097 - Bring back no arc by default.