1603696 - ChannelMediaDecoder.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1603690 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/media/ChannelMediaDecoder.cpp#242

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Manish Giri]

I'd like to work on this. I'll get started with reading the docs.

Comment 2

[Suyash Vardhan Mathur]

Even I'd like to work on this to get familiar with the Firefox contribution environment.

Comment 3

[Manish Giri]

(In reply to Suyash Vardhan Mathur from comment #2)

Even I'd like to work on this to get familiar with the Firefox contribution environment.

I’ve already started working on this, and have setup my environment. I’ll be submitting a patch soon. It would be good if you can pick another bug to contribute to.

Comment 4

[Manish Giri]

Attachment: Bug 1603696 Remove return at the end of void function. r?sylvestre

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04d34a298b65
Remove return at the end of void function. r=sylvestre

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/04d34a298b65