Launching a site specific browser logs "Invalid string label" to the console
Categories
(Firefox :: General, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
Whenever the user uses a page action we attempt to log some telemetry: https://searchfox.org/mozilla-central/rev/923eec8d2fb8078ebc7a33a9e1ce73eac01f7446/browser/modules/PageActions.jsm#351
There are a predefined list of labels available and the new ssb button isn't in the list: https://searchfox.org/mozilla-central/rev/923eec8d2fb8078ebc7a33a9e1ce73eac01f7446/toolkit/components/telemetry/Histograms.json#7313
So we log this error on every click. I could add the label to the list but it looks like the histogram itself expired 12 months ago. Should I just remove the histogram logging code instead?
|
||
Comment 1•4 years ago
|
||
Blargh. Yeah, this became a point in bug 1531132 at which point apparently there was "ongoing discussion". But we don't have slack history from then anymore. As best I can tell from my email, this may have been about savant / "telemetry all the UI" projects. Which then didn't happen, afaict, and aren't currently ongoing, so I'd suggest just removing it.
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23c48b2b5bdc Remove the long-expired telemetry logging for page action items. r=Gijs
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•