Consider whether we need to keep the page action histogram telemetry (was: "Invalid string label" error in console when pinning a tab from Page Action menu)
Categories
(Firefox :: Toolbars and Customization, defect, P3)
Tracking
()
People
(Reporter: rrosario, Unassigned)
References
Details
The error is coming from mozilla-central/toolkit/components/telemetry/core/TelemetryHistogram.cpp.
I am pretty sure that it's because "pinTab" wasn't added to the accepted "labels" for FX_PAGE_ACTION_* events in mozilla-central/toolkit/components/telemetry/Histograms.json. All those events expired in Firefox 64, so I was told they aren't collected anymore and I didn't have to add "pinTab" to the "labels" list.
So... I think this is a harmless error. But filing it anyway before somebody else does.
|
Reporter | |
Comment 1•6 years ago
|
||
:janerik does Comment 0 sound right to you? Any idea why that error is being logged?
|
||
Comment 2•6 years ago
|
||
It's indeed harmless, but maybe a bit spammy. Unfortunately we only check the expiration after checking the arguments (I think that's due to some refactoring I did a while ago, we should fix that on the Telemetry side).
It would be nice if you can just remove the expired histograms (that means removing it from Histograms.json as well as all code that tries to record this data).
|
|
Reporter | |
Updated•6 years ago
|
|
||
Comment 3•6 years ago
|
||
There's ongoing discussion about whether we want to keep (and renew) this telemetry, or want to remove it. What to do here depends on the outcome of that discussion.
|
|
||
Comment 4•5 years ago
|
||
Duping forward to where we hit this a second time...
Description
•