1603889 - Simplify the scrollbar preference setup.

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603889 - Simplify the scrollbar preference setup. r=smaug

So much plumbing to pass an enum down.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603889 - Remove AppWindow::GetContentScrollbarVisibility. r=smaug

There's only one test that can potentially rely on this, and still passes
with this patch:

toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js

More to the point, this doesn't work with e10s whatsoever already, and seems
content cannot change the scrollbar visibility anymore, and chrome code doesn't
do it either.

Depends on D57182

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603889 - Make ScrollbarsProp::SetVisible do nothing, and minor cleanup of surrounding code. r=smaug

This removes another dead caller of nsContentUtils::SetScrollbarVisibility.

Plus, before these patches, nsContentUtils::SetScrollbarVisibility didn't
invalidate layout in any way, so it's not like it'd work, even if the chrome
code would set the preference (which it doesn't).

Depends on D57184

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83a65c8e56c8
Simplify the scrollbar preference setup. r=smaug

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/83a65c8e56c8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/666ed2796ff3
Remove AppWindow::GetContentScrollbarVisibility. r=smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f96a10dcccc
Make ScrollbarsProp::SetVisible do nothing, and minor cleanup of surrounding code. r=smaug

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/666ed2796ff3
https://hg.mozilla.org/mozilla-central/rev/1f96a10dcccc