Fission iframes don't handle the scrolling="" attribute at all.
Categories
(Core :: DOM: Content Processes, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
<!doctype html>
<iframe src="https://crisal.io/tmp/file_bug590812.xml" scrolling="no"></iframe>
<iframe src="https://crisal.io/tmp/mask-image-resource.html" scrolling="yes"></iframe>
Both show scrollbars with Fission.
|
||
Comment 1•5 years ago
|
||
The priority flag is not set for this bug.
:jimm, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
Once bug 1602322 lands, layout/reftests/scrolling/[i]frame-scrolling-attr-[1|2].html will have test coverage for this, and we'll be able to remove the fails-if(browserIsFission) annotation.
|
Assignee | |
Comment 5•5 years ago
|
||
Right now we do the same thing in two pretty different code paths... That's not
great, so unify them.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D59629
|
||
Comment 8•5 years ago
|
||
Backed out 2 changesets (bug 1588791) for causing test_bug369370.html and test_transformed_scrolling_repaints_3.html to permafail
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=52e661ff161d361d8c59c38b7426330ade4531ee&failure_classification_id=2
backout: https://hg.mozilla.org/integration/autoland/rev/f86ebd59fa8b4b09717d6b36ce2b73f09fa694b9
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e4eb188ccbe0
https://hg.mozilla.org/mozilla-central/rev/05639d6591b3
|
||
Comment 11•5 years ago
|
||
Thanks Emilio! Looks like this fixed all but one of the failures in the layout/reftests/scrolling/[i]frame-scrolling-attr*
iframe-scrolling-attr-2.html seems to be still failing though. Linux reftests also got moved to ubuntu 18.04 since my last try push, so that might be another variable affecting this.
Here is a link to a failure
Emilio, could you take a look and decide if we need a new bug to fix this?
|
|
Assignee | |
Comment 12•5 years ago
|
||
The test works, but it expects the change to be synchronous, which for fission iframe it's not.
So that test is racy, gotta figure out how to wait for the message to be processed or something.
|
|
Assignee | |
Comment 13•5 years ago
|
||
Tim, do you know any easy way to wait until all the relevant IPC messages have been processed? Otherwise I guess I'll just rewrite the test to use postMessage or something.
|
|
||
Comment 14•5 years ago
|
||
Hmm, I do not. I think it might be a wider issue, I'm debugging a different reftest fission failure and I don't see anything that will guarantee an EffectsInfo ipc message will be delivered before the final snapshot. So we might need to figure something out more general.
Description
•