1603927 - [Wayland] Do not try to pause compositor when nsWindow is destroyed

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

nsWindow::HideWaylandWindow() could be called under nsWindow::Destroy(). In this case, we do not need to pause compositor. Current code hit assert failure.

• https://searchfox.org/mozilla-central/rev/2f09184ec781a2667feec87499d4b81b32b6c48e/widget/gtk/nsWindow.cpp#4452

It was called like the followig.
(gdb) info stack
#0 0x00007fffe8ee7497 in nsWindow::HideWaylandWindow() (this=0x7fffbe6e5c00)
at /home/sotaro/firefox_bld_dsk/mozilla-central/widget/gtk/nsWindow.cpp:4469
#1 0x00007fffe8ee4fab in nsWindow::NativeShow(bool) (this=0x7fffbe6e5c00, aAction=<optimized out>)
at /home/sotaro/firefox_bld_dsk/mozilla-central/widget/gtk/nsWindow.cpp:4565
#2 0x00007fffe8ee44f2 in nsWindow::Destroy() (this=0x7fffbe6e5c00)
at /home/sotaro/firefox_bld_dsk/mozilla-central/widget/gtk/nsWindow.cpp:716
#3 0x00007fffe8e98e13 in DestroyWidgetRunnable::Run() (this=0x7fffbf9fa160)
at /home/sotaro/firefox_bld_dsk/mozilla-central/view/nsView.cpp:120

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1603927 - Do not try to pause compositor when nsWindow is destroyed

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18a1b66855c
Do not try to pause compositor when nsWindow is destroyed r=stransky

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c18a1b66855c