1604064 - Cleanup js::BaseScript flag accessors

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Bug 1569063 added standard accessors for BaseScript::ImmutableFlags but did not remove pre-existing aliases. It makes sense to remove those aliases now for consistency.

As well, we should assert-the-world that flags have the same meaning before and after delazification and document the exceptions.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1604064 - Remove BaseScript::ImmutableFlags aliases. r?jandem

These aliases were historical inconsistencies between lazy and non-lazy
scripts and consistent names should now be used instead.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1604064 - Assert script flags are consistent when delazifying. r?jandem!,jorendorff!

Add a CheckFlagsOnDelazification helper method to check the script flags
entering and leaving the delazification process and documenting the
exceptions where the parsers generate different results.

Depends on D57250

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71ca86752153
Remove BaseScript::ImmutableFlags aliases. r=jandem
https://hg.mozilla.org/integration/autoland/rev/be456ba9f55c
Assert script flags are consistent when delazifying. r=jandem,jorendorff

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/71ca86752153
https://hg.mozilla.org/mozilla-central/rev/be456ba9f55c